Return-Path: Delivered-To: apmail-hbase-dev-archive@www.apache.org Received: (qmail 35699 invoked from network); 16 Dec 2010 08:15:04 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 16 Dec 2010 08:15:04 -0000 Received: (qmail 86360 invoked by uid 500); 16 Dec 2010 08:15:04 -0000 Delivered-To: apmail-hbase-dev-archive@hbase.apache.org Received: (qmail 86099 invoked by uid 500); 16 Dec 2010 08:15:03 -0000 Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hbase.apache.org Delivered-To: mailing list dev@hbase.apache.org Received: (qmail 86073 invoked by uid 99); 16 Dec 2010 08:15:02 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 16 Dec 2010 08:15:02 +0000 X-ASF-Spam-Status: No, hits=1.8 required=10.0 tests=FH_HELO_EQ_D_D_D_D,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (athena.apache.org: local policy) Received: from [184.73.217.71] (HELO ip-10-202-7-187.ec2.internal) (184.73.217.71) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 16 Dec 2010 08:14:57 +0000 Received: from ip-10-202-7-187.ec2.internal (localhost [127.0.0.1]) by ip-10-202-7-187.ec2.internal (Postfix) with ESMTP id 10AEC8A216; Thu, 16 Dec 2010 08:14:36 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Subject: Re: Review Request: hbase-3362 If .META. offline between OPENING and OPENED, then wrong server location in .META. is possible From: "Jonathan Gray" To: "Jonathan Gray" Date: Thu, 16 Dec 2010 08:14:36 -0000 Message-ID: <20101216081436.24974.12451@ip-10-202-7-187.ec2.internal> Cc: jiraposter@review.hbase.org,dev@hbase.apache.org,stack@duboce.net In-Reply-To: <20101216001427.26854.43769@ip-10-202-7-187.ec2.internal> References: <20101216001427.26854.43769@ip-10-202-7-187.ec2.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1298/#review2083 ----------------------------------------------------------- Ship it! a few small comments. i think the loop should change as described in my co= mment (busy loop w/ call to currentTimeMillis as i read it). otherwise +1,= good stuff. we need some tickle util class soon :) trunk/src/main/java/org/apache/hadoop/hbase/regionserver/handler/OpenRegion= Handler.java "on this server" should probably be left in comment to be clear what th= is is checking trunk/src/main/java/org/apache/hadoop/hbase/regionserver/handler/OpenRegion= Handler.java We were not previously but we should probably log this condition trunk/src/main/java/org/apache/hadoop/hbase/regionserver/handler/OpenRegion= Handler.java This is a busy wait loop? = Should we add a wait/notify on something passed to the thread and w/ a = timeout of the period? = And then we should probably also have some kind of max timeout. Even i= f minutes, there could be weird cluster state where the RS misses META avai= lability but someone else might handle it properly, so max timeout might be= good? trunk/src/main/java/org/apache/hadoop/hbase/regionserver/handler/OpenRegion= Handler.java whitespace trunk/src/main/java/org/apache/hadoop/hbase/regionserver/handler/OpenRegion= Handler.java maybe this should be warn. i think i'd want to see it and also logging= of stack trace (i don't see logging of it elsewhere) - Jonathan On 2010-12-15 16:14:27, stack wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.cloudera.org/r/1298/ > ----------------------------------------------------------- > = > (Updated 2010-12-15 16:14:27) > = > = > Review request for hbase and Jonathan Gray. > = > = > Summary > ------- > = > M src/main/java/org/apache/hadoop/hbase/regionserver/handler/OpenRegionHa= ndler.java > Removed stale comments and TODOs. > = > Added a 'version' datamenber, the znode edit version which we keep acros= s open process. > = > Refactored the setting of OPENING out into a method that is used in mult= iple places = > now rather than repeat code. Did this in new tickleOpening method. > = > Added new PostOpenDeployTasksThread which we run to do the postOpenDeplo= yTasks. > While its running we update OPENING state if its running a while. > = > = > This addresses bug hbase-3362. > http://issues.apache.org/jira/browse/hbase-3362 > = > = > Diffs > ----- > = > trunk/src/main/java/org/apache/hadoop/hbase/regionserver/handler/OpenRe= gionHandler.java 1049707 = > = > Diff: http://review.cloudera.org/r/1298/diff > = > = > Testing > ------- > = > Ran it on my cluster. Seems to work as the old code did. > = > = > Thanks, > = > stack > = >