hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Gray" <jg...@apache.org>
Subject Re: Review Request: HBASE-3305 Allow round-robin distribution for table created with multiple regions
Date Wed, 08 Dec 2010 03:06:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1271/#review2049
-----------------------------------------------------------

Ship it!


looks good, thanks ted!  i will commit the final patch to trunk.


trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
<http://review.cloudera.org/r/1271/#comment6456>

    line is > 80 chars but will fix on commit, don't worry


- Jonathan


On 2010-12-07 18:28:46, Ted Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.cloudera.org/r/1271/
> -----------------------------------------------------------
> 
> (Updated 2010-12-07 18:28:46)
> 
> 
> Review request for hbase, stack and Jonathan Gray.
> 
> 
> Summary
> -------
> 
> Adopted round-robin assignment as default for regions specified when table is created.
> 
> 
> This addresses bug HBASE-3305.
>     http://issues.apache.org/jira/browse/HBASE-3305
> 
> 
> Diffs
> -----
> 
>   trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java 1043216 
>   trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java 1043216 
>   trunk/src/main/java/org/apache/hadoop/hbase/master/LoadBalancer.java 1043216 
>   trunk/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java 1043216 
> 
> Diff: http://review.cloudera.org/r/1271/diff
> 
> 
> Testing
> -------
> 
> Put unit tests for this change inside TestAdmin.testCreateTableWithRegions()
> They passed.
> 
> 
> Thanks,
> 
> Ted
> 
>


Mime
View raw message