hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jean-Daniel Cryans" <jdcry...@apache.org>
Subject Review Request: SplitTransaction.splitStoreFiles slows splits a lot
Date Wed, 08 Dec 2010 00:38:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1273/
-----------------------------------------------------------

Review request for hbase.


Summary
-------

Patch that parallelizes the splitting of the files using ThreadPoolExecutor and Futures. The
code is a bit ugly, but does the job really well as shown during cluster testing (which also
uncovered HBASE-3318).

One new behavior this patch adds is that it's now possible to rollback a split because it
took too long to split the files. I did some testing with a timeout of 5 secs on my cluster,
even tho each machine did a few rollbacks the import went fine. The default is 30 seconds
and isn't in hbase-default.xml as I don't think anyone would really want to change that.


This addresses bug HBASE-3308.
    http://issues.apache.org/jira/browse/HBASE-3308


Diffs
-----

  /branches/0.90/src/main/java/org/apache/hadoop/hbase/regionserver/SplitTransaction.java
1043188 

Diff: http://review.cloudera.org/r/1273/diff


Testing
-------


Thanks,

Jean-Daniel


Mime
View raw message