Return-Path: Delivered-To: apmail-hbase-dev-archive@www.apache.org Received: (qmail 83579 invoked from network); 29 Nov 2010 19:29:50 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 29 Nov 2010 19:29:50 -0000 Received: (qmail 30700 invoked by uid 500); 29 Nov 2010 19:29:50 -0000 Delivered-To: apmail-hbase-dev-archive@hbase.apache.org Received: (qmail 30600 invoked by uid 500); 29 Nov 2010 19:29:50 -0000 Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hbase.apache.org Delivered-To: mailing list dev@hbase.apache.org Received: (qmail 30592 invoked by uid 99); 29 Nov 2010 19:29:50 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 29 Nov 2010 19:29:50 +0000 X-ASF-Spam-Status: No, hits=1.8 required=10.0 tests=FH_HELO_EQ_D_D_D_D,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (nike.apache.org: 184.73.217.71 is neither permitted nor denied by domain of stack@duboce.net) Received: from [184.73.217.71] (HELO ip-10-202-7-187.ec2.internal) (184.73.217.71) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 29 Nov 2010 19:29:43 +0000 Received: from ip-10-202-7-187.ec2.internal (localhost [127.0.0.1]) by ip-10-202-7-187.ec2.internal (Postfix) with ESMTP id 1672D8A20F; Mon, 29 Nov 2010 19:29:23 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Subject: Re: Review Request: Need to retain DeadServers to ensure we don't allow previously expired RS instances to rejoin cluster From: stack@duboce.net To: stack@duboce.net Date: Mon, 29 Nov 2010 19:29:23 -0000 Message-ID: <20101129192923.6101.48323@ip-10-202-7-187.ec2.internal> Cc: "Jonathan Gray" , jiraposter@review.hbase.org, dev@hbase.apache.org In-Reply-To: <20101129190433.6100.52769@ip-10-202-7-187.ec2.internal> References: <20101129190433.6100.52769@ip-10-202-7-187.ec2.internal> X-Virus-Checked: Checked by ClamAV on apache.org ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1259/#review2004 ----------------------------------------------------------- Ship it! branches/0.90/src/main/java/org/apache/hadoop/hbase/master/ServerManager.ja= va You can make this private now that its no longer referenced by Master? - stack On 2010-11-29 11:04:33, Jonathan Gray wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.cloudera.org/r/1259/ > ----------------------------------------------------------- > = > (Updated 2010-11-29 11:04:33) > = > = > Review request for hbase and stack. > = > = > Summary > ------- > = > We currently let go of dead servers once we finish their shutdown. We sh= ould hang on to them longer to deal with things like network partitions. > = > I'm not a fan of SoftReferences so I decided on another approach. DeadSe= rvers now has a maximum number of servers to hold on to in the set (default= 100). Once it reaches the max, it evicts the oldest. > = > More code than I had hoped but nothing too crazy. > = > = > This addresses bug HBASE-3282. > http://issues.apache.org/jira/browse/HBASE-3282 > = > = > Diffs > ----- > = > branches/0.90/src/main/java/org/apache/hadoop/hbase/master/DeadServer.j= ava 1040221 = > branches/0.90/src/main/java/org/apache/hadoop/hbase/master/HMaster.java= 1040221 = > branches/0.90/src/main/java/org/apache/hadoop/hbase/master/ServerManage= r.java 1040221 = > branches/0.90/src/main/java/org/apache/hadoop/hbase/master/handler/Serv= erShutdownHandler.java 1040221 = > = > Diff: http://review.cloudera.org/r/1259/diff > = > = > Testing > ------- > = > Running unit tests now. > = > = > Thanks, > = > Jonathan > = >