Return-Path: 
 <dev-return-21096-apmail-hbase-dev-archive=hbase.apache.org@hbase.apache.org>
Delivered-To: apmail-hbase-dev-archive@www.apache.org
Received: (qmail 50606 invoked from network); 10 Nov 2010 23:25:03 -0000
Received: from unknown (HELO mail.apache.org) (140.211.11.3)
  by 140.211.11.9 with SMTP; 10 Nov 2010 23:25:03 -0000
Received: (qmail 30802 invoked by uid 500); 10 Nov 2010 23:25:35 -0000
Delivered-To: apmail-hbase-dev-archive@hbase.apache.org
Received: (qmail 30752 invoked by uid 500); 10 Nov 2010 23:25:35 -0000
Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@hbase.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@hbase.apache.org>
List-Post: <mailto:dev@hbase.apache.org>
List-Id: <dev.hbase.apache.org>
Reply-To: dev@hbase.apache.org
Delivered-To: mailing list dev@hbase.apache.org
Received: (qmail 30739 invoked by uid 99); 10 Nov 2010 23:25:35 -0000
Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 Nov 2010 23:25:35 +0000
X-ASF-Spam-Status: No, hits=1.8 required=10.0
	tests=FH_HELO_EQ_D_D_D_D,FREEMAIL_FROM,SPF_NEUTRAL
X-Spam-Check-By: apache.org
Received-SPF: neutral (nike.apache.org: 184.73.217.71 is neither permitted nor
 denied by domain of ryanobjc@gmail.com)
Received: from [184.73.217.71] (HELO ip-10-202-7-187.ec2.internal)
 (184.73.217.71)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 Nov 2010 23:25:28 +0000
Received: from ip-10-202-7-187.ec2.internal (localhost [127.0.0.1])
	by ip-10-202-7-187.ec2.internal (Postfix) with ESMTP id B324E8A20F;
	Wed, 10 Nov 2010 23:25:07 +0000 (UTC)
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Subject: Re: Review Request: HBASE-3211 Key only filter
From: "Ryan Rawson" <ryanobjc@gmail.com>
To: "Kannan Muthukkaruppan" <kannan@facebook.com>, stack@duboce.net
Date: Wed, 10 Nov 2010 23:25:07 -0000
Message-ID: <20101110232507.9240.90919@ip-10-202-7-187.ec2.internal>
Cc: "Ryan Rawson" <ryanobjc@gmail.com>, jiraposter@review.hbase.org,
	dev@hbase.apache.org, "Jonathan Gray" <jgray@apache.org>
In-Reply-To: <20101110231926.9239.73744@ip-10-202-7-187.ec2.internal>
References: <20101110231926.9239.73744@ip-10-202-7-187.ec2.internal>
X-Virus-Checked: Checked by ClamAV on apache.org


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1208/#review1891
-----------------------------------------------------------



trunk/src/main/java/org/apache/hadoop/hbase/KeyValue.java
<http://review.cloudera.org/r/1208/#comment6117>

    I'm torn here, this is making the implementation easy, but KeyValues ha=
ve been immutable to date.  While no one shares KeyValues between threads o=
r scanners, and ideally no one should, this seems dangerous.
    =

    =



- Ryan


On 2010-11-10 15:19:26, Jonathan Gray wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.cloudera.org/r/1208/
> -----------------------------------------------------------
> =

> (Updated 2010-11-10 15:19:26)
> =

> =

> Review request for hbase, stack and Kannan Muthukkaruppan.
> =

> =

> Summary
> -------
> =

> Adds a new filter, KeyOnlyFilter.  The idea is that this will make it so =
only the key portion of all the KVs are returned.  Could imagine a few use =
cases where you just need the keys/index not the values.  We have one where=
 we have giant rows with big values and want to just get the qualifiers/ver=
sions w/o values.
> =

> Adds a new method in KeyValue, convertToKeyOnly().  From javadoc:
> =

>   /**
>    * Converts this KeyValue to only contain the key portion (the value is
>    * changed to be null).  This method does a full copy of the backing by=
te
>    * array and does not modify the original byte array of this KeyValue.
>    * <p>
>    * This method is used by {@link KeyOnlyFilter} and is an advanced feat=
ure of
>    * KeyValue, proceed with caution.
>    */
> =

> =

> This addresses bug HBASE-3211.
>     http://issues.apache.org/jira/browse/HBASE-3211
> =

> =

> Diffs
> -----
> =

>   trunk/src/main/java/org/apache/hadoop/hbase/KeyValue.java 1033617 =

>   trunk/src/main/java/org/apache/hadoop/hbase/filter/KeyOnlyFilter.java P=
RE-CREATION =

>   trunk/src/main/java/org/apache/hadoop/hbase/io/HbaseObjectWritable.java=
 1033617 =

>   trunk/src/test/java/org/apache/hadoop/hbase/TestKeyValue.java 1033617 =

>   trunk/src/test/java/org/apache/hadoop/hbase/filter/TestFilter.java 1033=
617 =

> =

> Diff: http://review.cloudera.org/r/1208/diff
> =

> =

> Testing
> -------
> =

> Test of the KV method added to TestKeyValue.  Test of KeyOnlyFilter added=
 to TestFilter.  Both passing.
> =

> =

> Thanks,
> =

> Jonathan
> =

>