Return-Path: Delivered-To: apmail-hbase-dev-archive@www.apache.org Received: (qmail 1724 invoked from network); 9 Nov 2010 05:16:27 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 9 Nov 2010 05:16:27 -0000 Received: (qmail 5340 invoked by uid 500); 9 Nov 2010 05:16:58 -0000 Delivered-To: apmail-hbase-dev-archive@hbase.apache.org Received: (qmail 5086 invoked by uid 500); 9 Nov 2010 05:16:55 -0000 Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hbase.apache.org Delivered-To: mailing list dev@hbase.apache.org Received: (qmail 5078 invoked by uid 99); 9 Nov 2010 05:16:55 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 09 Nov 2010 05:16:55 +0000 X-ASF-Spam-Status: No, hits=1.8 required=10.0 tests=FH_HELO_EQ_D_D_D_D,MIME_QP_LONG_LINE,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (nike.apache.org: 184.73.217.71 is neither permitted nor denied by domain of stack@duboce.net) Received: from [184.73.217.71] (HELO ip-10-202-7-187.ec2.internal) (184.73.217.71) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 09 Nov 2010 05:16:48 +0000 Received: from ip-10-202-7-187.ec2.internal (localhost [127.0.0.1]) by ip-10-202-7-187.ec2.internal (Postfix) with ESMTP id A539F8A20B; Tue, 9 Nov 2010 05:16:27 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Subject: Re: Review Request: hbase-3112 Enable and disable of table needs a bit of loving in new master From: stack@duboce.net To: "Jonathan Gray" Date: Tue, 09 Nov 2010 05:16:27 -0000 Message-ID: <20101109051627.9240.48577@ip-10-202-7-187.ec2.internal> Cc: jiraposter@review.hbase.org,dev@hbase.apache.org,stack@duboce.net In-Reply-To: <20101109010425.9240.3580@ip-10-202-7-187.ec2.internal> References: <20101109010425.9240.3580@ip-10-202-7-187.ec2.internal> X-Virus-Checked: Checked by ClamAV on apache.org > On 2010-11-08 17:04:25, Jonathan Gray wrote: > > I can live without the state-checking methods in ZKTable but it's fine,= no big deal as is. > > = > > Only issue is that we're hitting ZK on each assign(). > > = > > Otherwise, if tests are passing and it's working for you up on cluster,= I'm +1 on this. > > = > > If you add async/sync support, let's be sure to nail the javadoc. I want the state-checking methods to flag bad state transitions. On hitting zk on each assign, pardon me, I didn't grok what you were on abo= ut when you talked this up earlier. I get it now. Will fix. Tests are failing because I changed sematics; disable/enable are now async = where before they were sync. Will do your suggestion of creating a sync ve= rsion if only to make tests pass (should only be for use of tests). > On 2010-11-08 17:04:25, Jonathan Gray wrote: > > trunk/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java, lin= e 447 > > > > > > why describe 'enabling' state in our client API? do we let out 'en= abling' at all anywhere? > > = > > and do we need to make mention that if it seems to never finish, th= is method should be retried? ok. removed mention of states. > On 2010-11-08 17:04:25, Jonathan Gray wrote: > > trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.ja= va, line 659 > > > > > > isTableDisabling is actually a ZK read rather than checking in-memo= ry state. Should be move enabling/disabling to in-memory state as well? I= 'm not sure it's a good idea to have to read from ZK on every assign() call= , especially for something as rare as disabling. Will fix in next patch. - stack ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1187/#review1853 ----------------------------------------------------------- On 2010-11-08 16:09:44, stack wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.cloudera.org/r/1187/ > ----------------------------------------------------------- > = > (Updated 2010-11-08 16:09:44) > = > = > Review request for hbase and Jonathan Gray. > = > = > Summary > ------- > = > Renamed ZKTableDisable as ZKTable, making it a generic zk util for managi= ng 'tables'. > Added enabing/disabling states to table the current set of enabled/disabl= ed only. > = > M src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java > (createSetData): Added. > M src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java > Removed offlining region utility methods no longer used. > (We do it now over in MetaEditor) > M src/main/java/org/apache/hadoop/hbase/HRegionInfo.java > Javadoc. > M src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java > Add a base abstract class to do 'bulk assignments'. Redo > assignAllUserRegions to use subclass of new bulk assigner class. > Added isTableEnabled, disablingTable, enablingTable. > M src/main/java/org/apache/hadoop/hbase/master/handler/DisableTableHandle= r.java > Redid to use new bulk assigner class. > M src/main/java/org/apache/hadoop/hbase/master/handler/EnableTableHandler= .java > A Added TestZKTable > = > = > This addresses bug hbase-3112. > http://issues.apache.org/jira/browse/hbase-3112 > = > = > Diffs > ----- > = > trunk/src/main/java/org/apache/hadoop/hbase/HRegionInfo.java 1032652 = > trunk/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java 1032= 652 = > trunk/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.j= ava 1032652 = > trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.ja= va 1032652 = > trunk/src/main/java/org/apache/hadoop/hbase/master/BulkAssigner.java PR= E-CREATION = > trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java 1032652 = > trunk/src/main/java/org/apache/hadoop/hbase/master/handler/DeleteTableH= andler.java 1032652 = > trunk/src/main/java/org/apache/hadoop/hbase/master/handler/DisableTable= Handler.java 1032652 = > trunk/src/main/java/org/apache/hadoop/hbase/master/handler/EnableTableH= andler.java 1032652 = > trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 1= 032652 = > trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKTable.java PRE-= CREATION = > trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKTableDisable.ja= va 1032652 = > trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java 10326= 52 = > trunk/src/main/ruby/hbase/admin.rb 1032778 = > trunk/src/main/ruby/shell.rb 1032778 = > trunk/src/main/ruby/shell/commands/disable.rb 1032778 = > trunk/src/main/ruby/shell/commands/enable.rb 1032778 = > trunk/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java 10326= 52 = > trunk/src/test/java/org/apache/hadoop/hbase/master/TestMasterFailover.j= ava 1032652 = > trunk/src/test/java/org/apache/hadoop/hbase/zookeeper/TestZKTable.java = PRE-CREATION = > = > Diff: http://review.cloudera.org/r/1187/diff > = > = > Testing > ------- > = > = > Thanks, > = > stack > = >