Return-Path: Delivered-To: apmail-hbase-dev-archive@www.apache.org Received: (qmail 90564 invoked from network); 9 Nov 2010 00:59:44 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 9 Nov 2010 00:59:44 -0000 Received: (qmail 8345 invoked by uid 500); 9 Nov 2010 01:00:15 -0000 Delivered-To: apmail-hbase-dev-archive@hbase.apache.org Received: (qmail 8258 invoked by uid 500); 9 Nov 2010 01:00:14 -0000 Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hbase.apache.org Delivered-To: mailing list dev@hbase.apache.org Received: (qmail 8250 invoked by uid 99); 9 Nov 2010 01:00:14 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 09 Nov 2010 01:00:14 +0000 X-ASF-Spam-Status: No, hits=1.8 required=10.0 tests=FH_HELO_EQ_D_D_D_D,FREEMAIL_FROM,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (nike.apache.org: 184.73.217.71 is neither permitted nor denied by domain of ryanobjc@gmail.com) Received: from [184.73.217.71] (HELO ip-10-202-7-187.ec2.internal) (184.73.217.71) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 09 Nov 2010 01:00:07 +0000 Received: from ip-10-202-7-187.ec2.internal (localhost [127.0.0.1]) by ip-10-202-7-187.ec2.internal (Postfix) with ESMTP id 3768B8A20B; Tue, 9 Nov 2010 00:59:47 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Subject: Re: Review Request: HBASE-2989 MultiPut makes proper error handling impossible and leads to corrupted data From: "Ryan Rawson" To: "Ryan Rawson" , jiraposter@review.hbase.org, dev@hbase.apache.org Date: Tue, 09 Nov 2010 00:59:47 -0000 Message-ID: <20101109005947.9240.22181@ip-10-202-7-187.ec2.internal> In-Reply-To: <20101105084323.22264.54356@ip-10-202-7-187.ec2.internal> References: <20101105084323.22264.54356@ip-10-202-7-187.ec2.internal> X-Virus-Checked: Checked by ClamAV on apache.org ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1176/#review1855 ----------------------------------------------------------- trunk/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java people can selective not catch IE and then let their regular abort do i= t's job. trunk/src/main/java/org/apache/hadoop/hbase/client/HTable.java yes, absolutely, because at the end we check every single entry in the = results[] and if there are any failures (null, Throwable instances) we thro= w an exception. So one can be sure that everything is a Result during succe= ss, and if you get an exception you have the Throwable handy dandy in both = the results array and in thrown exception. = trunk/src/main/java/org/apache/hadoop/hbase/client/HTable.java this is a brand new method, never was in any previous 0.89 DR even. trunk/src/main/java/org/apache/hadoop/hbase/client/MultiResponse.java it could be either a Throwable or a Result. batch() shouldn't throw man= y exceptions, they should be identified and lined up with each index entry. trunk/src/test/java/org/apache/hadoop/hbase/client/MultiResponseTest.java I blame SVN! It was including my scratch work :-) - Ryan On 2010-11-05 01:43:22, Ryan Rawson wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.cloudera.org/r/1176/ > ----------------------------------------------------------- > = > (Updated 2010-11-05 01:43:22) > = > = > Review request for hbase. > = > = > Summary > ------- > = > This is a change to batch() that substantially increases the error handli= ng. Included is a new Exception type with a lot more details of what faile= d and where. Users will be able to also query the thrown exception to see = if there is a possible cluster problem. They will be able to log the serve= r addresses that had issues. = > = > The TestMultiParallel test case passes, I need to run the rest. > = > = > This addresses bug HBASE-2898. > http://issues.apache.org/jira/browse/HBASE-2898 > = > = > Diffs > ----- > = > trunk/pom.xml 1031470 = > trunk/src/main/java/org/apache/hadoop/hbase/client/HConnection.java 103= 1470 = > trunk/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.j= ava 1031470 = > trunk/src/main/java/org/apache/hadoop/hbase/client/HTable.java 1031470 = > trunk/src/main/java/org/apache/hadoop/hbase/client/HTableInterface.java= 1031470 = > trunk/src/main/java/org/apache/hadoop/hbase/client/MultiResponse.java 1= 031470 = > trunk/src/main/java/org/apache/hadoop/hbase/client/RetriesExhaustedWith= DetailsException.java PRE-CREATION = > trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.= java 1031470 = > trunk/src/main/java/org/apache/hadoop/hbase/regionserver/RegionServerSt= oppedException.java 1031470 = > trunk/src/main/java/org/apache/hadoop/hbase/rest/client/RemoteHTable.ja= va 1031470 = > trunk/src/test/java/org/apache/hadoop/hbase/client/MultiResponseTest.ja= va PRE-CREATION = > trunk/src/test/java/org/apache/hadoop/hbase/client/TestMultiParallel.ja= va 1031470 = > = > Diff: http://review.cloudera.org/r/1176/diff > = > = > Testing > ------- > = > = > Thanks, > = > Ryan > = >