Return-Path: Delivered-To: apmail-hbase-dev-archive@www.apache.org Received: (qmail 34477 invoked from network); 8 Nov 2010 20:01:28 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 8 Nov 2010 20:01:28 -0000 Received: (qmail 82640 invoked by uid 500); 8 Nov 2010 20:01:59 -0000 Delivered-To: apmail-hbase-dev-archive@hbase.apache.org Received: (qmail 82504 invoked by uid 500); 8 Nov 2010 20:01:59 -0000 Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hbase.apache.org Delivered-To: mailing list dev@hbase.apache.org Received: (qmail 82496 invoked by uid 99); 8 Nov 2010 20:01:59 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 08 Nov 2010 20:01:59 +0000 X-ASF-Spam-Status: No, hits=1.8 required=10.0 tests=FH_HELO_EQ_D_D_D_D,MIME_QP_LONG_LINE,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (athena.apache.org: 184.73.217.71 is neither permitted nor denied by domain of stack@duboce.net) Received: from [184.73.217.71] (HELO ip-10-202-7-187.ec2.internal) (184.73.217.71) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 08 Nov 2010 20:01:53 +0000 Received: from ip-10-202-7-187.ec2.internal (localhost [127.0.0.1]) by ip-10-202-7-187.ec2.internal (Postfix) with ESMTP id DBC9B8A20A; Mon, 8 Nov 2010 20:01:32 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Subject: Re: Review Request: hbase-3112 Enable and disable of table needs a bit of loving in new master From: stack@duboce.net To: "Jonathan Gray" Date: Mon, 08 Nov 2010 20:01:32 -0000 Message-ID: <20101108200132.9240.9272@ip-10-202-7-187.ec2.internal> Cc: jiraposter@review.hbase.org,dev@hbase.apache.org,stack@duboce.net In-Reply-To: <20101108195055.9240.39861@ip-10-202-7-187.ec2.internal> References: <20101108195055.9240.39861@ip-10-202-7-187.ec2.internal> > On 2010-11-08 11:50:55, Jonathan Gray wrote: > > trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.ja= va, line 1143 > > > > > > What does this mean? done vs. not done? I think we should be more= descriptive in the logging (if done, then we've completed assignment of re= gions on cluster startup). But if not done, on startup, what does this mea= n? There's comment later that RIT timeouts should fix it up, so should be = in log message here? Or on startup case of bulk assign, should we fail sta= rtup here if this doesn't pass? Removed it. It confuses (see above for exhibit A). If problem doing bulk assign, we'll crash out master. Otherwise, timeout o= f RIT should fix bulk assign stragglers. > On 2010-11-08 11:50:55, Jonathan Gray wrote: > > trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.ja= va, line 1149 > > > > > > Can we move all this stuff into a separate class? AssignmentManage= r is getting huge. Maybe BulkAssign could be class that contains all these= other class definitions? > > = > > Also gives good opportunity in class comment to describe in general= how this stuff works. BulkAssigner class comment says -- perhaps a little curtly -- what it does?= I'll move it out. The implementations though I'll leave beside where the= y are used -- in class. - stack ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1187/#review1840 ----------------------------------------------------------- On 2010-11-08 11:47:12, stack wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.cloudera.org/r/1187/ > ----------------------------------------------------------- > = > (Updated 2010-11-08 11:47:12) > = > = > Review request for hbase and Jonathan Gray. > = > = > Summary > ------- > = > Renamed ZKTableDisable as ZKTable, making it a generic zk util for managi= ng 'tables'. > Added enabing/disabling states to table the current set of enabled/disabl= ed only. > = > M src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java > (createSetData): Added. > M src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java > Removed offlining region utility methods no longer used. > (We do it now over in MetaEditor) > M src/main/java/org/apache/hadoop/hbase/HRegionInfo.java > Javadoc. > M src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java > Add a base abstract class to do 'bulk assignments'. Redo > assignAllUserRegions to use subclass of new bulk assigner class. > Added isTableEnabled, disablingTable, enablingTable. > M src/main/java/org/apache/hadoop/hbase/master/handler/DisableTableHandle= r.java > Redid to use new bulk assigner class. > M src/main/java/org/apache/hadoop/hbase/master/handler/EnableTableHandler= .java > A Added TestZKTable > = > = > This addresses bug hbase-3112. > http://issues.apache.org/jira/browse/hbase-3112 > = > = > Diffs > ----- > = > trunk/src/main/java/org/apache/hadoop/hbase/HRegionInfo.java 1032652 = > trunk/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.j= ava 1032652 = > trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.ja= va 1032652 = > trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java 1032652 = > trunk/src/main/java/org/apache/hadoop/hbase/master/handler/DeleteTableH= andler.java 1032652 = > trunk/src/main/java/org/apache/hadoop/hbase/master/handler/DisableTable= Handler.java 1032652 = > trunk/src/main/java/org/apache/hadoop/hbase/master/handler/EnableTableH= andler.java 1032652 = > trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 1= 032652 = > trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKTable.java PRE-= CREATION = > trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKTableDisable.ja= va 1032652 = > trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java 10326= 52 = > trunk/src/test/java/org/apache/hadoop/hbase/master/TestMasterFailover.j= ava 1032652 = > trunk/src/test/java/org/apache/hadoop/hbase/zookeeper/TestZKTable.java = PRE-CREATION = > = > Diff: http://review.cloudera.org/r/1187/diff > = > = > Testing > ------- > = > = > Thanks, > = > stack > = >