hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jean-Daniel Cryans" <jdcry...@apache.org>
Subject Review Request: Master passes IP and not hostname back to region server
Date Tue, 30 Nov 2010 19:45:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1262/
-----------------------------------------------------------

Review request for hbase.


Summary
-------

Changes:
 - In HMaster, instead of passing an IP as String we now pass the HSA object completely.
 - In HRegionServer, I cleared a bunch of crufty comments and handle the HSA passed by the
master.
 - In HServerInfo, I saw that the hostname wasn't reset when setting the HSA. Fixed.
 - In HServerAddress, I fixed a few places that wasn't explicitly using hostnames and changed
the serialization to pass a hostname instead of an IP address.


This addresses bug HBASE-3286.
    http://issues.apache.org/jira/browse/HBASE-3286


Diffs
-----

  /trunk/src/main/java/org/apache/hadoop/hbase/HServerAddress.java 1040669 
  /trunk/src/main/java/org/apache/hadoop/hbase/HServerInfo.java 1040669 
  /trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java 1040669 
  /trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 1040669 

Diff: http://review.cloudera.org/r/1262/diff


Testing
-------

Works on my MBP (I was seeing the same issue but since there's only 1 RS it didn't have any
bad effect) and my 10 machines Ubuntu cluster. 


Thanks,

Jean-Daniel


Mime
View raw message