hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars George" <larsgeo...@apache.org>
Subject Re: Review Request: [rest] Filter for gzip/deflate content encoding that wraps both input and output side
Date Fri, 26 Nov 2010 14:44:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1254/#review1981
-----------------------------------------------------------

Ship it!


Looks great! RB did show some white spaces added unnecessarily, I assume you could remove
those on commit.

- Lars


On 2010-11-26 02:16:22, Andrew Purtell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.cloudera.org/r/1254/
> -----------------------------------------------------------
> 
> (Updated 2010-11-26 02:16:22)
> 
> 
> Review request for hbase.
> 
> 
> Summary
> -------
> 
> After HBASE-3275 the REST gateway uses Jetty's GzipFilter to will return gzip or deflate
encoded content to the client if the client requested it using the appropriate Accept-Encoding
header. However Jetty's GzipFilter only wraps output side processing.
> 
> This patch implements a filter that also wraps input side processing, so clients can
submit compressed PUT or POST bodies.
> 
> 
> This addresses bug HBASE-3279.
>     http://issues.apache.org/jira/browse/HBASE-3279
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/hadoop/hbase/rest/Main.java 54866b6 
>   src/main/java/org/apache/hadoop/hbase/rest/filter/GZIPRequestStream.java PRE-CREATION

>   src/main/java/org/apache/hadoop/hbase/rest/filter/GZIPRequestWrapper.java PRE-CREATION

>   src/main/java/org/apache/hadoop/hbase/rest/filter/GZIPResponseStream.java PRE-CREATION

>   src/main/java/org/apache/hadoop/hbase/rest/filter/GZIPResponseWrapper.java PRE-CREATION

>   src/main/java/org/apache/hadoop/hbase/rest/filter/GzipFilter.java PRE-CREATION 
>   src/test/java/org/apache/hadoop/hbase/rest/HBaseRESTTestingUtility.java 5e943ec 
>   src/test/java/org/apache/hadoop/hbase/rest/TestGzipFilter.java PRE-CREATION 
> 
> Diff: http://review.cloudera.org/r/1254/diff
> 
> 
> Testing
> -------
> 
> New unit test, passes.
> 
> 
> Thanks,
> 
> Andrew
> 
>


Mime
View raw message