hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From st...@duboce.net
Subject Review Request: hbase-3267 close_region shell command breaks region
Date Wed, 24 Nov 2010 23:09:00 GMT

This is an automatically generated e-mail. To reply, visit:

Review request for hbase and Jonathan Gray.


So, things are different in the new master.  Close region should close region.  Not close
and then reopen.  To close and reopen elsewhere, thats an unassign or a move (both of which
were missing from shell but which are added in this patch).  I fixed the close so that its
a close that does not touch zk... the region is just closed on the regionserver.  No going
to zk makes it so the close no longer makes for complaint.  Close is dangerous though in that
the region is now permanently offline (I updated the close help to explain this is so).  
To address it being permanently offline, I added a new assign to the shell. 

While in here, I removed commands that no longer make senses such as enable_region and disable_region.

M src/main/java/org/apache/hadoop/hbase/master/HMaster.java
  Change move implementation so can pass an empty host.
  Empty host means move to random location rather than
  explicit server.
  Added assign, unassign
M src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
  (clearRegionPlan): Added.
M src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java
  Improved move javadoc.  Added assign, unassign.
M src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
  Improved javadoc. Added assign and unassign.
M src/main/ruby/hbase/admin.rb
  Added balancer, balance_switch, assign, unassign, removed
  zk, enable_region and disable_region (the latter make no sense
  anymore now disable/enable is done differently).
D src/main/ruby/shell/commands/zk.rb
A src/main/ruby/shell/commands/assign.rb
A src/main/ruby/shell/commands/balance_switch.rb
D src/main/ruby/shell/commands/disable_region.rb
A src/main/ruby/shell/commands/balancer.rb
A src/main/ruby/shell/commands/unassign.rb
D src/main/ruby/shell/commands/enable_region.rb
A src/main/ruby/shell/commands/move.rb
M src/main/ruby/shell/commands/close_region.rb
  Fixed up help
M src/main/ruby/shell.rb
  Added and removed commands.  

This addresses bug hbase-3267.


  trunk/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java 1038768 
  trunk/src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java 1038768 
  trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java 1038768 
  trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java 1038768 
  trunk/src/main/ruby/hbase/admin.rb 1038768 
  trunk/src/main/ruby/shell.rb 1038768 
  trunk/src/main/ruby/shell/commands/assign.rb PRE-CREATION 
  trunk/src/main/ruby/shell/commands/balance_switch.rb PRE-CREATION 
  trunk/src/main/ruby/shell/commands/balancer.rb PRE-CREATION 
  trunk/src/main/ruby/shell/commands/close_region.rb 1038768 
  trunk/src/main/ruby/shell/commands/disable_region.rb 1038768 
  trunk/src/main/ruby/shell/commands/enable_region.rb 1038768 
  trunk/src/main/ruby/shell/commands/move.rb PRE-CREATION 
  trunk/src/main/ruby/shell/commands/unassign.rb PRE-CREATION 
  trunk/src/main/ruby/shell/commands/zk.rb 1038768 

Diff: http://review.cloudera.org/r/1250/diff


I tested shell here on my little cluster.



View raw message