hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Gray" <jg...@apache.org>
Subject Review Request: HBASE-3168 Sanity date and time check when a region server joins the cluster
Date Wed, 10 Nov 2010 00:30:53 GMT

This is an automatically generated e-mail. To reply, visit:

Review request for hbase and stack.


This is patch from Jeff Whiting.  I then did little bits of polish and slim down of the unit

I uncovered very odd coupling of LogsCleaner being instantiated within ServerManager, though
we don't use it there and it doesn't use SM.  So that's refactored out into HMaster and is
started up/shut down with start/stopServiceThreads().

Changes from Jeff patch:
- Moved pulling maxSkew from config into constructor rather than doing it on each call
- Cleaned up the logging message a bit and changed from DEBUG to WARN
- HRS side, use EnvironmentEdgeManager rather than System.currentTimeMillis directly
- Changes test to operate directly on ServerManager. I had to do a bit of refactoring of ServerManager
to get this to work and it's nothing something anyone new would have pulled the trigger on
(moving stuff into another class instead of the weird unnecessary coupling to ServerManager).

This addresses bug HBASE-3168.


  trunk/src/main/java/org/apache/hadoop/hbase/ClockOutOfSyncException.java PRE-CREATION 
  trunk/src/main/java/org/apache/hadoop/hbase/ipc/HBaseRPCProtocolVersion.java 1033288 
  trunk/src/main/java/org/apache/hadoop/hbase/ipc/HMasterRegionInterface.java 1033288 
  trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java 1033288 
  trunk/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java 1033288 
  trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 1033288 
  trunk/src/test/java/org/apache/hadoop/hbase/master/TestClockSkewDetection.java PRE-CREATION

Diff: http://review.cloudera.org/r/1193/diff


New added test passes.



View raw message