hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From st...@duboce.net
Subject Re: Review Request: hbase-3112 Enable and disable of table needs a bit of loving in new master
Date Tue, 09 Nov 2010 17:50:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1187/
-----------------------------------------------------------

(Updated 2010-11-09 09:50:33.321899)


Review request for hbase and Jonathan Gray.


Changes
-------

Ok. All table state is now managed by ZKTable, moved out of AM.  It also keeps cache of states
to save on zk ensemble roundtrips.  I think I've addressed all of your review comments now
Jon.


Summary
-------

Renamed ZKTableDisable as ZKTable, making it a generic zk util for managing 'tables'.
Added enabing/disabling states to table the current set of enabled/disabled only.

M src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java
  (createSetData): Added.
M src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
  Removed offlining region utility methods no longer used.
  (We do it now over in MetaEditor)
M src/main/java/org/apache/hadoop/hbase/HRegionInfo.java
  Javadoc.
M src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
  Add a base abstract class to do 'bulk assignments'.  Redo
  assignAllUserRegions to use subclass of new bulk assigner class.
  Added isTableEnabled, disablingTable, enablingTable.
M src/main/java/org/apache/hadoop/hbase/master/handler/DisableTableHandler.java
  Redid to use new bulk assigner class.
M src/main/java/org/apache/hadoop/hbase/master/handler/EnableTableHandler.java
A Added TestZKTable


This addresses bug hbase-3112.
    http://issues.apache.org/jira/browse/hbase-3112


Diffs (updated)
-----

  trunk/src/main/java/org/apache/hadoop/hbase/HRegionInfo.java 1032841 
  trunk/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java 1032841 
  trunk/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java 1032841 
  trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java 1032841 
  trunk/src/main/java/org/apache/hadoop/hbase/master/BulkAssigner.java PRE-CREATION 
  trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java 1032841 
  trunk/src/main/java/org/apache/hadoop/hbase/master/LoadBalancer.java 1032841 
  trunk/src/main/java/org/apache/hadoop/hbase/master/handler/ClosedRegionHandler.java 1032841

  trunk/src/main/java/org/apache/hadoop/hbase/master/handler/DeleteTableHandler.java 1032841

  trunk/src/main/java/org/apache/hadoop/hbase/master/handler/DisableTableHandler.java 1032841

  trunk/src/main/java/org/apache/hadoop/hbase/master/handler/EnableTableHandler.java 1032841

  trunk/src/main/java/org/apache/hadoop/hbase/master/handler/OpenedRegionHandler.java 1032841

  trunk/src/main/java/org/apache/hadoop/hbase/master/handler/ServerShutdownHandler.java 1032841

  trunk/src/main/java/org/apache/hadoop/hbase/master/handler/TableEventHandler.java 1032841

  trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 1032841 
  trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKTable.java PRE-CREATION 
  trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKTableDisable.java 1032841 
  trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java 1032841 
  trunk/src/main/ruby/hbase/admin.rb 1032841 
  trunk/src/main/ruby/shell.rb 1032841 
  trunk/src/main/ruby/shell/commands/disable.rb 1032841 
  trunk/src/main/ruby/shell/commands/enable.rb 1032841 
  trunk/src/main/ruby/shell/commands/is_disabled.rb PRE-CREATION 
  trunk/src/main/ruby/shell/commands/is_enabled.rb PRE-CREATION 
  trunk/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java 1032841 
  trunk/src/test/java/org/apache/hadoop/hbase/master/TestMasterFailover.java 1032841 
  trunk/src/test/java/org/apache/hadoop/hbase/zookeeper/TestZKTable.java PRE-CREATION 

Diff: http://review.cloudera.org/r/1187/diff


Testing
-------


Thanks,

stack


Mime
View raw message