hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From st...@duboce.net
Subject Re: Review Request: HBASE-2989 MultiPut makes proper error handling impossible and leads to corrupted data
Date Tue, 09 Nov 2010 00:52:13 GMT

This is an automatically generated e-mail. To reply, visit:

Patch looks great.  Needs the test filled out before +1 and do all unit tests pass?  It changes
a bunch of critical code so wouldn't be surprised if unexpected side effects.


    You didn't mean this, right?  We can't have direct cloudera dependency.


    No one depends on these?


    review board is showing a bunch of white space on these lines?  Tabs?


    You changing public API here?
    I suppose we are but only in HCM which is rarely used by other than internals... disregard
this comment since I see you convert it in HTable below to an IOE.


    Hmmm... would make life easier if we just let out the IE.


    Long line.


    Yeah, cleaner if IE is let out (I suppose).


    This is kinda ugly.  For sure exceptions have been purged here?


    Adding an IE here is ok?  Is this a new method in 0.90?


    Oh, ok... then IE is fine.


    Could there be exception here or its always Result?  If always Result why change type
to Object?


    Missing class comment on what this doohickey does


    Hey man, great test!  Can you add something in here?  Smile.

- stack

On 2010-11-05 01:43:22, Ryan Rawson wrote:
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.cloudera.org/r/1176/
> -----------------------------------------------------------
> (Updated 2010-11-05 01:43:22)
> Review request for hbase.
> Summary
> -------
> This is a change to batch() that substantially increases the error handling.  Included
is a new Exception type with a lot more details of what failed and where.  Users will be able
to also query the thrown exception to see if there is a possible cluster problem.  They will
be able to log the server addresses that had issues.  
> The TestMultiParallel test case passes, I need to run the rest.
> This addresses bug HBASE-2898.
>     http://issues.apache.org/jira/browse/HBASE-2898
> Diffs
> -----
>   trunk/pom.xml 1031470 
>   trunk/src/main/java/org/apache/hadoop/hbase/client/HConnection.java 1031470 
>   trunk/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java 1031470

>   trunk/src/main/java/org/apache/hadoop/hbase/client/HTable.java 1031470 
>   trunk/src/main/java/org/apache/hadoop/hbase/client/HTableInterface.java 1031470 
>   trunk/src/main/java/org/apache/hadoop/hbase/client/MultiResponse.java 1031470 
>   trunk/src/main/java/org/apache/hadoop/hbase/client/RetriesExhaustedWithDetailsException.java
>   trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 1031470

>   trunk/src/main/java/org/apache/hadoop/hbase/regionserver/RegionServerStoppedException.java
>   trunk/src/main/java/org/apache/hadoop/hbase/rest/client/RemoteHTable.java 1031470 
>   trunk/src/test/java/org/apache/hadoop/hbase/client/MultiResponseTest.java PRE-CREATION

>   trunk/src/test/java/org/apache/hadoop/hbase/client/TestMultiParallel.java 1031470 
> Diff: http://review.cloudera.org/r/1176/diff
> Testing
> -------
> Thanks,
> Ryan

View raw message