hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Gray" <jg...@apache.org>
Subject Re: Review Request: HBASE-3048: Unify major/minor compactions
Date Sat, 06 Nov 2010 22:50:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1185/
-----------------------------------------------------------

(Updated 2010-11-06 15:50:30.615330)


Review request for hbase, stack, Kannan Muthukkaruppan, and Ryan Rawson.


Changes
-------

Minor cleanup of whitespace and stuff.


Summary
-------

This is a rebased patch from Amit.  This was internally reviewed but we may want some minor
modifications for 0.90 with the new InternalScanner, if possible.  (suggestion from ryan on
jira)


This addresses bug HBASE-3048.
    http://issues.apache.org/jira/browse/HBASE-3048


Diffs (updated)
-----

  trunk/src/main/java/org/apache/hadoop/hbase/regionserver/MinorCompactingStoreScanner.java
1032175 
  trunk/src/main/java/org/apache/hadoop/hbase/regionserver/ScanQueryMatcher.java 1032175 
  trunk/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java 1032175 
  trunk/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java 1032175 
  trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompaction.java 1032175 
  trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestMinorCompactingStoreScanner.java
1032175 

Diff: http://review.cloudera.org/r/1185/diff


Testing
-------

Lot's of good new additions by Amit to TestCompaction which passes.


Thanks,

Jonathan


Mime
View raw message