hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From st...@duboce.net
Subject Re: Review Request: Log rolling archives files prematurely
Date Fri, 05 Nov 2010 21:51:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1181/#review1825
-----------------------------------------------------------

Ship it!


Looks good to me (after chatting more with j-d)


/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java
<http://review.cloudera.org/r/1181/#comment5902>

    This is not your comment but I don't understand what its trying to say... can you fix?


- stack


On 2010-11-05 14:23:30, Jean-Daniel Cryans wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.cloudera.org/r/1181/
> -----------------------------------------------------------
> 
> (Updated 2010-11-05 14:23:30)
> 
> 
> Review request for hbase.
> 
> 
> Summary
> -------
> 
> Removes the +1, -1 madness that I described in the jira and adds a unit test for log
cleaning.
> 
> 
> This addresses bug HBASE-3198.
>     http://issues.apache.org/jira/browse/HBASE-3198
> 
> 
> Diffs
> -----
> 
>   /trunk/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java 1031797 
>   /trunk/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLog.java 1031797

> 
> Diff: http://review.cloudera.org/r/1181/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jean-Daniel
> 
>


Mime
View raw message