hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Purtell" <apurt...@apache.org>
Subject Review Request: [rest] tests use deprecated foundation
Date Thu, 04 Nov 2010 21:32:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1168/
-----------------------------------------------------------

Review request for hbase.


Summary
-------

The REST module unit tests are based on HBaseClusterTestCase, which is deprecated and possibly
now also broken. This patch updates the REST tests to use JUnit4 and HBaseTestingUtility.


This also restores the test disabled for HBASE-3195.

I see the excess whitespace in the diff and will fix on commit.


This addresses bug HBASE-2564.
    http://issues.apache.org/jira/browse/HBASE-2564


Diffs
-----

  src/test/java/org/apache/hadoop/hbase/rest/BROKE_TestTransform.java 8d7b42d 
  src/test/java/org/apache/hadoop/hbase/rest/HBaseRESTClusterTestBase.java 950f79b 
  src/test/java/org/apache/hadoop/hbase/rest/HBaseRESTTestingUtility.java PRE-CREATION 
  src/test/java/org/apache/hadoop/hbase/rest/TestRowResource.java 7aa9d8b 
  src/test/java/org/apache/hadoop/hbase/rest/TestScannerResource.java 4c6a9d6 
  src/test/java/org/apache/hadoop/hbase/rest/TestScannersWithFilters.java dcba6a3 
  src/test/java/org/apache/hadoop/hbase/rest/TestSchemaResource.java e38a842 
  src/test/java/org/apache/hadoop/hbase/rest/TestStatusResource.java 9ec9e4c 
  src/test/java/org/apache/hadoop/hbase/rest/TestTableResource.java a8a7fb4 
  src/test/java/org/apache/hadoop/hbase/rest/TestTransform.java PRE-CREATION 
  src/test/java/org/apache/hadoop/hbase/rest/TestVersionResource.java 2a1ce33 
  src/test/java/org/apache/hadoop/hbase/rest/client/TestRemoteAdmin.java 3692564 
  src/test/java/org/apache/hadoop/hbase/rest/client/TestRemoteTable.java 56b2899 

Diff: http://review.cloudera.org/r/1168/diff


Testing
-------

All rewritten unit tests pass locally. Ran them twice. 


Thanks,

Andrew


Mime
View raw message