hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jean-Daniel Cryans" <jdcry...@apache.org>
Subject Re: Review Request: Client needs to reconnect if it expires its zk session
Date Thu, 04 Nov 2010 19:34:44 GMT


> On 2010-11-04 12:30:24, stack wrote:
> > /trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java, line
326
> > <http://review.cloudera.org/r/1167/diff/1/?file=16666#file16666line326>
> >
> >     Why a new exception?  Why not pass the one that got us here? (Or, maybe there
isn't one? Or you can't get at it)

Yeah there's no exception leading us there, it's the ZK event. Will add more documentation
tho.


- Jean-Daniel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1167/#review1804
-----------------------------------------------------------


On 2010-11-04 11:49:08, Jean-Daniel Cryans wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.cloudera.org/r/1167/
> -----------------------------------------------------------
> 
> (Updated 2010-11-04 11:49:08)
> 
> 
> Review request for hbase.
> 
> 
> Summary
> -------
> 
> Changes ZKW to send the SessionExpiredException in the abort call so that clients can
intercept it and reconnect to ZooKeeper by first clearing up their state and establishing
a new connection.
> 
> 
> This addresses bug HBASE-3095.
>     http://issues.apache.org/jira/browse/HBASE-3095
> 
> 
> Diffs
> -----
> 
>   /trunk/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java 1030759

>   /trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java 1030759

>   /trunk/src/test/java/org/apache/hadoop/hbase/TestZooKeeper.java 1030759 
> 
> Diff: http://review.cloudera.org/r/1167/diff
> 
> 
> Testing
> -------
> 
> Adapted the client session expiration unit test.
> 
> 
> Thanks,
> 
> Jean-Daniel
> 
>


Mime
View raw message