hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Gray" <jg...@apache.org>
Subject Re: Review Request: Cleanup of RIT timeouts and server shutdown handling
Date Mon, 01 Nov 2010 19:08:13 GMT


> On 2010-11-01 12:04:42, stack wrote:
> > trunk/src/main/java/org/apache/hadoop/hbase/master/handler/ServerShutdownHandler.java,
line 167
> > <http://review.cloudera.org/r/1143/diff/4/?file=16342#file16342line167>
> >
> >     Want to document the return?

It's in the javadoc:     * Returns true if specified region should be assigned, false if not.

Just didn't put it in the @return... can fix that up on commit


- Jonathan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1143/#review1753
-----------------------------------------------------------


On 2010-11-01 11:47:35, Jonathan Gray wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.cloudera.org/r/1143/
> -----------------------------------------------------------
> 
> (Updated 2010-11-01 11:47:35)
> 
> 
> Review request for hbase and stack.
> 
> 
> Summary
> -------
> 
> Does cleanup of RIT timeouts according to document in progress.  Still finishing document
but I'd like to get this patch tested before finalizing it.
> 
> Also found some strange stuff in server shutdown handling that could have easily led
to some double assignment issues that stack was seeing.
> 
> 
> This addresses bug HBASE-3181.
>     http://issues.apache.org/jira/browse/HBASE-3181
> 
> 
> Diffs
> -----
> 
>   trunk/src/main/java/org/apache/hadoop/hbase/catalog/MetaReader.java 1029789 
>   trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java 1029789 
>   trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java 1029789 
>   trunk/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java 1029789 
>   trunk/src/main/java/org/apache/hadoop/hbase/master/handler/ClosedRegionHandler.java
1029789 
>   trunk/src/main/java/org/apache/hadoop/hbase/master/handler/EnableTableHandler.java
1029789 
>   trunk/src/main/java/org/apache/hadoop/hbase/master/handler/OpenedRegionHandler.java
1029789 
>   trunk/src/main/java/org/apache/hadoop/hbase/master/handler/ServerShutdownHandler.java
1029789 
>   trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKAssign.java 1029789 
>   trunk/src/test/java/org/apache/hadoop/hbase/master/TestMasterFailover.java 1029789

>   trunk/src/test/java/org/apache/hadoop/hbase/master/TestRollingRestart.java 1029789

> 
> Diff: http://review.cloudera.org/r/1143/diff
> 
> 
> Testing
> -------
> 
> Working on tests now.  This definitely changes some behavior that is tested in the new
TestMasterFailover so need to figure if the test should change or whether we need to handle
things like CLOSING.  Maybe let it timeout a few times?
> 
> 
> Thanks,
> 
> Jonathan
> 
>


Mime
View raw message