hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From st...@duboce.net
Subject Re: Review Request: HBASE-3154: HBase RPC should support timeout (Hairong's patch)
Date Mon, 01 Nov 2010 17:27:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1142/#review1745
-----------------------------------------------------------


This looks right.  Does it work?  There is no test.  I put it up on my little cluster and
stuff still works so its not breaking anything.

- stack


On 2010-10-31 12:45:13, Jonathan Gray wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.cloudera.org/r/1142/
> -----------------------------------------------------------
> 
> (Updated 2010-10-31 12:45:13)
> 
> 
> Review request for hbase, stack and Kannan Muthukkaruppan.
> 
> 
> Summary
> -------
> 
> This patch is from Hairong.  Just helping out by putting it up on RB.
> 
> This adds a global, configurable timeout for all HBase RPCs.  Uses new config parameter
'hbase.rpc.timeout' rather than overloading the lease period.
> 
> 
> This addresses bug HBASE-3154.
>     http://issues.apache.org/jira/browse/HBASE-3154
> 
> 
> Diffs
> -----
> 
>   trunk/src/main/java/org/apache/hadoop/hbase/HConstants.java 1029423 
>   trunk/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java 1029423

>   trunk/src/main/java/org/apache/hadoop/hbase/ipc/HBaseClient.java 1029423 
>   trunk/src/main/java/org/apache/hadoop/hbase/ipc/HBaseRPC.java 1029423 
>   trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 1029423

> 
> Diff: http://review.cloudera.org/r/1142/diff
> 
> 
> Testing
> -------
> 
> Not actually sure.  I know that we've committed this internally at FB and I think Hairong
did testing on it.
> 
> 
> Thanks,
> 
> Jonathan
> 
>


Mime
View raw message