hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Gray" <jg...@apache.org>
Subject Re: Review Request: Cleanup of RIT timeouts and server shutdown handling
Date Mon, 01 Nov 2010 06:06:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1143/
-----------------------------------------------------------

(Updated 2010-10-31 23:06:55.505816)


Review request for hbase and stack.


Changes
-------

Latest patch.  Works with 5000 regions on TRR.

TRR: Success!  Found expected number of 5002 regions
-------------------------------------------------------------------------------
Test set: org.apache.hadoop.hbase.master.TestRollingRestart
-------------------------------------------------------------------------------
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1,227.177 sec


Summary
-------

Does cleanup of RIT timeouts according to document in progress.  Still finishing document
but I'd like to get this patch tested before finalizing it.

Also found some strange stuff in server shutdown handling that could have easily led to some
double assignment issues that stack was seeing.


This addresses bug HBASE-3181.
    http://issues.apache.org/jira/browse/HBASE-3181


Diffs (updated)
-----

  trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java 1029507 
  trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java 1029507 
  trunk/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java 1029507 
  trunk/src/main/java/org/apache/hadoop/hbase/master/handler/ClosedRegionHandler.java 1029507

  trunk/src/main/java/org/apache/hadoop/hbase/master/handler/EnableTableHandler.java 1029507

  trunk/src/main/java/org/apache/hadoop/hbase/master/handler/OpenedRegionHandler.java 1029507

  trunk/src/main/java/org/apache/hadoop/hbase/master/handler/ServerShutdownHandler.java 1029507

  trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKAssign.java 1029507 
  trunk/src/test/java/org/apache/hadoop/hbase/master/TestMasterFailover.java 1029507 
  trunk/src/test/java/org/apache/hadoop/hbase/master/TestRollingRestart.java 1029507 

Diff: http://review.cloudera.org/r/1143/diff


Testing
-------

Working on tests now.  This definitely changes some behavior that is tested in the new TestMasterFailover
so need to figure if the test should change or whether we need to handle things like CLOSING.
 Maybe let it timeout a few times?


Thanks,

Jonathan


Mime
View raw message