Return-Path: Delivered-To: apmail-hbase-dev-archive@www.apache.org Received: (qmail 70172 invoked from network); 31 Oct 2010 23:20:14 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 31 Oct 2010 23:20:14 -0000 Received: (qmail 49750 invoked by uid 500); 31 Oct 2010 23:20:45 -0000 Delivered-To: apmail-hbase-dev-archive@hbase.apache.org Received: (qmail 49577 invoked by uid 500); 31 Oct 2010 23:20:45 -0000 Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hbase.apache.org Delivered-To: mailing list dev@hbase.apache.org Received: (qmail 49555 invoked by uid 99); 31 Oct 2010 23:20:45 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 31 Oct 2010 23:20:45 +0000 X-ASF-Spam-Status: No, hits=1.8 required=10.0 tests=FH_HELO_EQ_D_D_D_D,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (nike.apache.org: local policy) Received: from [184.73.217.71] (HELO ip-10-202-7-187.ec2.internal) (184.73.217.71) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 31 Oct 2010 23:20:38 +0000 Received: from ip-10-202-7-187.ec2.internal (localhost [127.0.0.1]) by ip-10-202-7-187.ec2.internal (Postfix) with ESMTP id BD3E28A208; Sun, 31 Oct 2010 23:20:17 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Subject: Review Request: Cleanup of RIT timeouts and server shutdown handling From: "Jonathan Gray" To: stack@duboce.net Date: Sun, 31 Oct 2010 23:20:17 -0000 Message-ID: <20101031232017.20638.61584@ip-10-202-7-187.ec2.internal> Cc: "Jonathan Gray" , jiraposter@review.hbase.org, dev@hbase.apache.org X-Virus-Checked: Checked by ClamAV on apache.org ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1143/ ----------------------------------------------------------- Review request for hbase and stack. Summary ------- Does cleanup of RIT timeouts according to document in progress. Still fini= shing document but I'd like to get this patch tested before finalizing it. Also found some strange stuff in server shutdown handling that could have e= asily led to some double assignment issues that stack was seeing. This addresses bug HBASE-3181. http://issues.apache.org/jira/browse/HBASE-3181 Diffs ----- trunk/src/main/java/org/apache/hadoop/hbase/HRegionInfo.java 1029466 = trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java= 1029466 = trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java 1029466 = trunk/src/main/java/org/apache/hadoop/hbase/master/handler/ClosedRegionHa= ndler.java 1029466 = trunk/src/main/java/org/apache/hadoop/hbase/master/handler/EnableTableHan= dler.java 1029466 = trunk/src/main/java/org/apache/hadoop/hbase/master/handler/OpenedRegionHa= ndler.java 1029466 = trunk/src/main/java/org/apache/hadoop/hbase/master/handler/ServerShutdown= Handler.java 1029466 = trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKAssign.java 10294= 66 = Diff: http://review.cloudera.org/r/1143/diff Testing ------- Working on tests now. This definitely changes some behavior that is tested= in the new TestMasterFailover so need to figure if the test should change = or whether we need to handle things like CLOSING. Maybe let it timeout a f= ew times? Thanks, Jonathan