Return-Path: Delivered-To: apmail-hbase-dev-archive@www.apache.org Received: (qmail 31326 invoked from network); 30 Oct 2010 04:54:18 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 30 Oct 2010 04:54:18 -0000 Received: (qmail 30347 invoked by uid 500); 30 Oct 2010 04:54:18 -0000 Delivered-To: apmail-hbase-dev-archive@hbase.apache.org Received: (qmail 30275 invoked by uid 500); 30 Oct 2010 04:54:17 -0000 Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hbase.apache.org Delivered-To: mailing list dev@hbase.apache.org Received: (qmail 30261 invoked by uid 99); 30 Oct 2010 04:54:17 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 30 Oct 2010 04:54:17 +0000 X-ASF-Spam-Status: No, hits=1.8 required=10.0 tests=FH_HELO_EQ_D_D_D_D,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (athena.apache.org: local policy) Received: from [184.73.217.71] (HELO ip-10-202-7-187.ec2.internal) (184.73.217.71) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 30 Oct 2010 04:54:12 +0000 Received: from ip-10-202-7-187.ec2.internal (localhost [127.0.0.1]) by ip-10-202-7-187.ec2.internal (Postfix) with ESMTP id 2946B8A206; Sat, 30 Oct 2010 04:53:51 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Subject: Re: Review Request: Add TimeRange support into Increment to optimize for counters that are partitioned on time From: "Jonathan Gray" To: "Ryan Rawson" , thekhemani@facebook.com, stack@duboce.net Date: Sat, 30 Oct 2010 04:53:51 -0000 Message-ID: <20101030045351.786.49938@ip-10-202-7-187.ec2.internal> Cc: "Jonathan Gray" , jiraposter@review.hbase.org, dev@hbase.apache.org In-Reply-To: <20101030041911.785.44193@ip-10-202-7-187.ec2.internal> References: <20101030041911.785.44193@ip-10-202-7-187.ec2.internal> > On 2010-10-29 21:19:11, Ryan Rawson wrote: > > trunk/src/main/java/org/apache/hadoop/hbase/client/Increment.java, line= 274 > > > > > > technically Increment.java has never shipped in a published version= of HBase so we wont need to bump any version numbers I think. +1 - Jonathan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1132/#review1720 ----------------------------------------------------------- On 2010-10-29 19:42:21, Jonathan Gray wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.cloudera.org/r/1132/ > ----------------------------------------------------------- > = > (Updated 2010-10-29 19:42:21) > = > = > Review request for hbase, stack, Ryan Rawson, and khemani. > = > = > Summary > ------- > = > TimeRange now part of Increment. Adds new methods into Increment w/ java= doc. Adds code in our increment operation to set this onto the Gets we use. > = > = > This addresses bug HBASE-3162. > http://issues.apache.org/jira/browse/HBASE-3162 > = > = > Diffs > ----- > = > trunk/src/main/java/org/apache/hadoop/hbase/client/Increment.java 10289= 36 = > trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 1= 028936 = > = > Diff: http://review.cloudera.org/r/1132/diff > = > = > Testing > ------- > = > increment tests passing. > = > = > Thanks, > = > Jonathan > = >