Return-Path: Delivered-To: apmail-hbase-dev-archive@www.apache.org Received: (qmail 80657 invoked from network); 30 Oct 2010 02:16:41 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 30 Oct 2010 02:16:41 -0000 Received: (qmail 77625 invoked by uid 500); 30 Oct 2010 02:16:41 -0000 Delivered-To: apmail-hbase-dev-archive@hbase.apache.org Received: (qmail 77599 invoked by uid 500); 30 Oct 2010 02:16:41 -0000 Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hbase.apache.org Delivered-To: mailing list dev@hbase.apache.org Received: (qmail 77591 invoked by uid 99); 30 Oct 2010 02:16:41 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 30 Oct 2010 02:16:41 +0000 X-ASF-Spam-Status: No, hits=1.8 required=10.0 tests=FH_HELO_EQ_D_D_D_D,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (nike.apache.org: local policy) Received: from [184.73.217.71] (HELO ip-10-202-7-187.ec2.internal) (184.73.217.71) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 30 Oct 2010 02:16:34 +0000 Received: from ip-10-202-7-187.ec2.internal (localhost [127.0.0.1]) by ip-10-202-7-187.ec2.internal (Postfix) with ESMTP id F401F8A206; Sat, 30 Oct 2010 02:16:13 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Subject: Review Request: HBASE-2253: Show Block cache hit ratio for requests where cacheBlocks=true From: "Jonathan Gray" To: "Jean-Daniel Cryans" , stack@duboce.net Date: Sat, 30 Oct 2010 02:16:13 -0000 Message-ID: <20101030021613.786.14239@ip-10-202-7-187.ec2.internal> Cc: "Jonathan Gray" , jiraposter@review.hbase.org, dev@hbase.apache.org X-Virus-Checked: Checked by ClamAV on apache.org ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1131/ ----------------------------------------------------------- Review request for hbase, stack and Jean-Daniel Cryans. Summary ------- LruBlockCache now tracks the hitCachingCount and missCachingCount. These a= re hits/misses when caching of blocks is turned on so the hitCachingRatio d= oes not include the impact of reads which were not going to cache. Exposes this new ratio in metrics and in all of the logging/toString method= s. Small optimization in CacheStats to not track hit/miss/access, just compute= access from hit+miss. This addresses bug HBASE-2253. http://issues.apache.org/jira/browse/HBASE-2253 Diffs ----- trunk/src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCache.java 1028= 936 = trunk/src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java 1028936 = trunk/src/main/java/org/apache/hadoop/hbase/io/hfile/LruBlockCache.java 1= 028936 = trunk/src/main/java/org/apache/hadoop/hbase/io/hfile/SimpleBlockCache.jav= a 1028936 = trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.ja= va 1028936 = trunk/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionSe= rverMetrics.java 1028936 = trunk/src/test/java/org/apache/hadoop/hbase/io/hfile/TestLruBlockCache.ja= va 1028936 = Diff: http://review.cloudera.org/r/1131/diff Testing ------- Ran the block cache test. Thanks, Jonathan