Return-Path: Delivered-To: apmail-hbase-dev-archive@www.apache.org Received: (qmail 94379 invoked from network); 25 Oct 2010 19:31:10 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 25 Oct 2010 19:31:10 -0000 Received: (qmail 80770 invoked by uid 500); 25 Oct 2010 19:31:09 -0000 Delivered-To: apmail-hbase-dev-archive@hbase.apache.org Received: (qmail 80670 invoked by uid 500); 25 Oct 2010 19:31:09 -0000 Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hbase.apache.org Delivered-To: mailing list dev@hbase.apache.org Received: (qmail 80661 invoked by uid 99); 25 Oct 2010 19:31:09 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 25 Oct 2010 19:31:09 +0000 X-ASF-Spam-Status: No, hits=1.8 required=10.0 tests=FH_HELO_EQ_D_D_D_D,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (athena.apache.org: local policy) Received: from [184.73.217.71] (HELO ip-10-202-7-187.ec2.internal) (184.73.217.71) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 25 Oct 2010 19:31:04 +0000 Received: from ip-10-202-7-187.ec2.internal (localhost [127.0.0.1]) by ip-10-202-7-187.ec2.internal (Postfix) with ESMTP id D96D28A206; Mon, 25 Oct 2010 19:30:43 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Subject: Re: Review Request: TestRollingRestart From: "Jonathan Gray" To: stack@duboce.net Date: Mon, 25 Oct 2010 19:30:43 -0000 Message-ID: <20101025193043.786.98149@ip-10-202-7-187.ec2.internal> Cc: "Jonathan Gray" , jiraposter@review.hbase.org, dev@hbase.apache.org In-Reply-To: <20101025192103.785.11160@ip-10-202-7-187.ec2.internal> References: <20101025192103.785.11160@ip-10-202-7-187.ec2.internal> > On 2010-10-25 12:21:03, stack wrote: > > Whats wrong w/ this? Looks good to me. Other tests would be nice but = this does what rolling restart does now. Does it pass? Nothing is wrong with it except that it passes. Your restarts have shown w= eird bugs and this isn't showing it (I don't have my proposed fix applied). Need to add some concurrent RS stopping though rolling restart should not e= ven do that. - Jonathan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1090/#review1651 ----------------------------------------------------------- On 2010-10-25 10:15:12, Jonathan Gray wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.cloudera.org/r/1090/ > ----------------------------------------------------------- > = > (Updated 2010-10-25 10:15:12) > = > = > Review request for hbase and stack. > = > = > Summary > ------- > = > First go at a TestRollingRestart. Needs more work / harder tests per com= ments in the test. > = > = > Diffs > ----- > = > trunk/src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java 1026= 935 = > trunk/src/test/java/org/apache/hadoop/hbase/master/TestRollingRestart.j= ava PRE-CREATION = > = > Diff: http://review.cloudera.org/r/1090/diff > = > = > Testing > ------- > = > = > Thanks, > = > Jonathan > = >