Return-Path: Delivered-To: apmail-hbase-dev-archive@www.apache.org Received: (qmail 96192 invoked from network); 23 Oct 2010 06:30:56 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 23 Oct 2010 06:30:56 -0000 Received: (qmail 77183 invoked by uid 500); 23 Oct 2010 06:30:55 -0000 Delivered-To: apmail-hbase-dev-archive@hbase.apache.org Received: (qmail 77081 invoked by uid 500); 23 Oct 2010 06:30:53 -0000 Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hbase.apache.org Delivered-To: mailing list dev@hbase.apache.org Received: (qmail 77072 invoked by uid 99); 23 Oct 2010 06:30:53 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 23 Oct 2010 06:30:53 +0000 X-ASF-Spam-Status: No, hits=1.8 required=10.0 tests=FH_HELO_EQ_D_D_D_D,MIME_QP_LONG_LINE,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (athena.apache.org: local policy) Received: from [184.73.217.71] (HELO ip-10-202-7-187.ec2.internal) (184.73.217.71) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 23 Oct 2010 06:30:47 +0000 Received: from ip-10-202-7-187.ec2.internal (localhost [127.0.0.1]) by ip-10-202-7-187.ec2.internal (Postfix) with ESMTP id 307998A206; Sat, 23 Oct 2010 06:30:27 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Subject: Re: Review Request: Unit test and fix for multi-threaded executor service From: "Jonathan Gray" To: stack@duboce.net Date: Sat, 23 Oct 2010 06:30:27 -0000 Message-ID: <20101023063027.11862.74166@ip-10-202-7-187.ec2.internal> Cc: "Jonathan Gray" , jiraposter@review.hbase.org, dev@hbase.apache.org In-Reply-To: <20101023062728.11862.60966@ip-10-202-7-187.ec2.internal> References: <20101023062728.11862.60966@ip-10-202-7-187.ec2.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1064/#review1632 ----------------------------------------------------------- Ship it! Looks good to me. Nice test :) - Jonathan On 2010-10-22 23:27:28, Jonathan Gray wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.cloudera.org/r/1064/ > ----------------------------------------------------------- > = > (Updated 2010-10-22 23:27:28) > = > = > Review request for hbase and stack. > = > = > Summary > ------- > = > See HBASE-3139 > = > = > This addresses bug hbase-3139. > http://issues.apache.org/jira/browse/hbase-3139 > = > = > Diffs > ----- > = > trunk/src/main/java/org/apache/hadoop/hbase/executor/ExecutorService.ja= va 1026564 = > trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java 1026564 = > trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.= java 1026564 = > trunk/src/test/java/org/apache/hadoop/hbase/executor/TestExecutorServic= e.java 1026564 = > = > Diff: http://review.cloudera.org/r/1064/diff > = > = > Testing > ------- > = > = > Thanks, > = > Jonathan > = >