Return-Path: Delivered-To: apmail-hbase-dev-archive@www.apache.org Received: (qmail 85206 invoked from network); 22 Oct 2010 23:38:38 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 22 Oct 2010 23:38:38 -0000 Received: (qmail 16315 invoked by uid 500); 22 Oct 2010 23:38:37 -0000 Delivered-To: apmail-hbase-dev-archive@hbase.apache.org Received: (qmail 16222 invoked by uid 500); 22 Oct 2010 23:38:37 -0000 Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hbase.apache.org Delivered-To: mailing list dev@hbase.apache.org Received: (qmail 16214 invoked by uid 99); 22 Oct 2010 23:38:37 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 22 Oct 2010 23:38:37 +0000 X-ASF-Spam-Status: No, hits=1.8 required=10.0 tests=FH_HELO_EQ_D_D_D_D,FREEMAIL_FROM,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (nike.apache.org: 184.73.217.71 is neither permitted nor denied by domain of ryanobjc@gmail.com) Received: from [184.73.217.71] (HELO ip-10-202-7-187.ec2.internal) (184.73.217.71) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 22 Oct 2010 23:38:31 +0000 Received: from ip-10-202-7-187.ec2.internal (localhost [127.0.0.1]) by ip-10-202-7-187.ec2.internal (Postfix) with ESMTP id 831F28A204; Fri, 22 Oct 2010 23:38:10 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Subject: Re: Review Request: HBASE-2514 RegionServer should refuse to be assigned a region that use LZO when LZO isn't available From: "Ryan Rawson" To: "Ryan Rawson" , jiraposter@review.hbase.org, dev@hbase.apache.org, stack@duboce.net Date: Fri, 22 Oct 2010 23:38:10 -0000 Message-ID: <20101022233810.11863.44062@ip-10-202-7-187.ec2.internal> In-Reply-To: <20101022224355.11863.43556@ip-10-202-7-187.ec2.internal> References: <20101022224355.11863.43556@ip-10-202-7-187.ec2.internal> X-Virus-Checked: Checked by ClamAV on apache.org ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1046/ ----------------------------------------------------------- (Updated 2010-10-22 16:38:10.455573) Review request for hbase. Summary ------- RegionServer should refuse to be assigned a region that use LZO when LZO is= n't available - instead of checking regions during open, i do a check and throw during th= e construction of the RS that is is able to instantiate the listed codecs. This addresses bug HBASE-2514. http://issues.apache.org/jira/browse/HBASE-2514 Diffs (updated) ----- trunk/CHANGES.txt 1024074 = trunk/src/main/java/org/apache/hadoop/hbase/io/hfile/Compression.java 102= 4073 = trunk/src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java 1024073 = trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 102= 4073 = trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.ja= va 1024074 = trunk/src/main/java/org/apache/hadoop/hbase/util/CompressionTest.java 102= 4073 = trunk/src/test/java/org/apache/hadoop/hbase/util/TestCompressionTest.java= PRE-CREATION = Diff: http://review.cloudera.org/r/1046/diff Testing ------- Thanks, Ryan