Return-Path: Delivered-To: apmail-hbase-dev-archive@www.apache.org Received: (qmail 82141 invoked from network); 22 Oct 2010 23:21:32 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 22 Oct 2010 23:21:32 -0000 Received: (qmail 7731 invoked by uid 500); 22 Oct 2010 23:21:32 -0000 Delivered-To: apmail-hbase-dev-archive@hbase.apache.org Received: (qmail 7591 invoked by uid 500); 22 Oct 2010 23:21:32 -0000 Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hbase.apache.org Delivered-To: mailing list dev@hbase.apache.org Received: (qmail 7583 invoked by uid 99); 22 Oct 2010 23:21:32 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 22 Oct 2010 23:21:32 +0000 X-ASF-Spam-Status: No, hits=1.8 required=10.0 tests=FH_HELO_EQ_D_D_D_D,MIME_QP_LONG_LINE,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (athena.apache.org: 184.73.217.71 is neither permitted nor denied by domain of stack@duboce.net) Received: from [184.73.217.71] (HELO ip-10-202-7-187.ec2.internal) (184.73.217.71) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 22 Oct 2010 23:21:26 +0000 Received: from ip-10-202-7-187.ec2.internal (localhost [127.0.0.1]) by ip-10-202-7-187.ec2.internal (Postfix) with ESMTP id 1AA4F8A204; Fri, 22 Oct 2010 23:21:06 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Subject: Re: Review Request: HBASE-2514 RegionServer should refuse to be assigned a region that use LZO when LZO isn't available From: stack@duboce.net To: "Ryan Rawson" , jiraposter@review.hbase.org, dev@hbase.apache.org, stack@duboce.net Date: Fri, 22 Oct 2010 23:21:06 -0000 Message-ID: <20101022232106.11862.23454@ip-10-202-7-187.ec2.internal> In-Reply-To: <20101022224355.11863.43556@ip-10-202-7-187.ec2.internal> References: <20101022224355.11863.43556@ip-10-202-7-187.ec2.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1046/#review1628 ----------------------------------------------------------- Chatting offline w/ R and J-D, this patch is good if hfiles but no good if = no files yet (Ryan pointed this out). So, we need combo of this and J-Ds s= chema check. RS won't go down. RS just won't deploy a region that require= s an uninstalled codec. I think thats the way to go. trunk/src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java Remove TODO trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java Where is 'feature' documented? - stack On 2010-10-22 15:43:55, Ryan Rawson wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.cloudera.org/r/1046/ > ----------------------------------------------------------- > = > (Updated 2010-10-22 15:43:55) > = > = > Review request for hbase. > = > = > Summary > ------- > = > RegionServer should refuse to be assigned a region that use LZO when LZO = isn't available > = > - instead of checking regions during open, i do a check and throw during = the construction of the RS that is is able to instantiate the listed codecs. > = > = > This addresses bug HBASE-2514. > http://issues.apache.org/jira/browse/HBASE-2514 > = > = > Diffs > ----- > = > trunk/CHANGES.txt 1024074 = > trunk/src/main/java/org/apache/hadoop/hbase/io/hfile/Compression.java 1= 024073 = > trunk/src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java 1024073 = > trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.= java 1024074 = > trunk/src/main/java/org/apache/hadoop/hbase/util/CompressionTest.java 1= 024073 = > trunk/src/test/java/org/apache/hadoop/hbase/util/TestCompressionTest.ja= va PRE-CREATION = > = > Diff: http://review.cloudera.org/r/1046/diff > = > = > Testing > ------- > = > = > Thanks, > = > Ryan > = >