Return-Path: Delivered-To: apmail-hbase-dev-archive@www.apache.org Received: (qmail 78141 invoked from network); 21 Oct 2010 20:27:36 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 21 Oct 2010 20:27:36 -0000 Received: (qmail 86608 invoked by uid 500); 21 Oct 2010 20:27:36 -0000 Delivered-To: apmail-hbase-dev-archive@hbase.apache.org Received: (qmail 86544 invoked by uid 500); 21 Oct 2010 20:27:35 -0000 Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hbase.apache.org Delivered-To: mailing list dev@hbase.apache.org Received: (qmail 86531 invoked by uid 99); 21 Oct 2010 20:27:35 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 21 Oct 2010 20:27:35 +0000 X-ASF-Spam-Status: No, hits=1.8 required=10.0 tests=FH_HELO_EQ_D_D_D_D,MIME_QP_LONG_LINE,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (nike.apache.org: local policy) Received: from [184.73.217.71] (HELO ip-10-202-7-187.ec2.internal) (184.73.217.71) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 21 Oct 2010 20:27:29 +0000 Received: from ip-10-202-7-187.ec2.internal (localhost [127.0.0.1]) by ip-10-202-7-187.ec2.internal (Postfix) with ESMTP id 3EDC58A204; Thu, 21 Oct 2010 20:27:08 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Subject: Re: Review Request: hbase-2658 REST (stargate) TableRegionModel Regions need to be updated to work w/ new region naming convention from HBASE-2531 From: "Andrew Purtell" To: "Andrew Purtell" Date: Thu, 21 Oct 2010 20:27:08 -0000 Message-ID: <20101021202708.11862.86020@ip-10-202-7-187.ec2.internal> Cc: jiraposter@review.hbase.org,dev@hbase.apache.org,stack@duboce.net In-Reply-To: <20101021183511.11863.5164@ip-10-202-7-187.ec2.internal> References: <20101021183511.11863.5164@ip-10-202-7-187.ec2.internal> X-Virus-Checked: Checked by ClamAV on apache.org ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1063/#review1602 ----------------------------------------------------------- Ship it! Looks good. - Andrew On 2010-10-21 11:35:11, stack wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.cloudera.org/r/1063/ > ----------------------------------------------------------- > = > (Updated 2010-10-21 11:35:11) > = > = > Review request for hbase and Andrew Purtell. > = > = > Summary > ------- > = > Andrew, can you look at this? Its making the TableRegionModel do the new= HRegionInfo name format. Has a few tests even. I also changed the TestTa= bleResource back to old style compare of region names and now it passes. > = > = > This addresses bug hbase-2658. > http://issues.apache.org/jira/browse/hbase-2658 > = > = > Diffs > ----- > = > trunk/src/main/java/org/apache/hadoop/hbase/HRegionInfo.java 1026078 = > trunk/src/main/java/org/apache/hadoop/hbase/HTableDescriptor.java 10260= 78 = > trunk/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java 1= 026078 = > trunk/src/main/java/org/apache/hadoop/hbase/rest/model/TableRegionModel= .java 1026078 = > trunk/src/main/java/org/apache/hadoop/hbase/util/MetaUtils.java 1026078 = > trunk/src/test/java/org/apache/hadoop/hbase/rest/TestTableResource.java= 1026078 = > trunk/src/test/java/org/apache/hadoop/hbase/rest/model/TestTableRegionM= odel.java 1026078 = > = > Diff: http://review.cloudera.org/r/1063/diff > = > = > Testing > ------- > = > = > Thanks, > = > stack > = >