Return-Path: Delivered-To: apmail-hbase-dev-archive@www.apache.org Received: (qmail 50103 invoked from network); 21 Oct 2010 00:54:31 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 21 Oct 2010 00:54:31 -0000 Received: (qmail 77317 invoked by uid 500); 21 Oct 2010 00:54:30 -0000 Delivered-To: apmail-hbase-dev-archive@hbase.apache.org Received: (qmail 77293 invoked by uid 500); 21 Oct 2010 00:54:30 -0000 Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hbase.apache.org Delivered-To: mailing list dev@hbase.apache.org Received: (qmail 77285 invoked by uid 99); 21 Oct 2010 00:54:30 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 21 Oct 2010 00:54:30 +0000 X-ASF-Spam-Status: No, hits=1.8 required=10.0 tests=FH_HELO_EQ_D_D_D_D,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (nike.apache.org: local policy) Received: from [184.73.217.71] (HELO ip-10-202-7-187.ec2.internal) (184.73.217.71) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 21 Oct 2010 00:54:24 +0000 Received: from ip-10-202-7-187.ec2.internal (localhost [127.0.0.1]) by ip-10-202-7-187.ec2.internal (Postfix) with ESMTP id E9F788A204; Thu, 21 Oct 2010 00:54:03 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Subject: Re: Review Request: hbase-2998 rolling-restart.sh shouldn't rely on zoo.cfg From: "Jonathan Gray" To: "Jonathan Gray" , "Jean-Daniel Cryans" Date: Thu, 21 Oct 2010 00:54:03 -0000 Message-ID: <20101021005403.11862.53567@ip-10-202-7-187.ec2.internal> Cc: jiraposter@review.hbase.org,dev@hbase.apache.org,stack@duboce.net In-Reply-To: <20101020235125.11863.47997@ip-10-202-7-187.ec2.internal> References: <20101020235125.11863.47997@ip-10-202-7-187.ec2.internal> X-Virus-Checked: Checked by ClamAV on apache.org ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1057/#review1594 ----------------------------------------------------------- Looking good! trunk/src/main/java/org/apache/hadoop/hbase/regionserver/ShutdownHook.java = - Jonathan On 2010-10-20 16:51:25, stack wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.cloudera.org/r/1057/ > ----------------------------------------------------------- > = > (Updated 2010-10-20 16:51:25) > = > = > Review request for hbase, Jean-Daniel Cryans and Jonathan Gray. > = > = > Summary > ------- > = > Fix 'hbase zkcli' so it reads zk ensemble location from hbase config/zoo.= cfg. This fixes rolling restart. Patch also includes fix so rolling resta= rts work on new master. > = > A src/test/java/org/apache/hadoop/hbase/zookeeper/TestZooKeeperMainServer= Arg.java > Test for new TZMSA class. > M src/main/java/org/apache/hadoop/hbase/zookeeper/ZKServerTool.java > Minor edit of javadoc. > A src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperMainServerArg.= java > Tool to emit what ZooKeeperMain wants for a server argument. > M src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java > (isAbort): Added. > M src/main/java/org/apache/hadoop/hbase/regionserver/ShutdownHook.java > Shutdown hook now needs to startup region shutdowns since new > master changed how shutdown sequence runs. > M src/main/java/org/apache/hadoop/hbase/regionserver/handler/OpenRegionHa= ndler.java > Don't do opens if server is stopped. > M src/main/java/org/apache/hadoop/hbase/master/handler/OpenedRegionHandle= r.java > Minor formatting. > M bin/hbase > Run new ZKMSA tool to figure '-server host:port' to pass ZKM > M bin/hbase-daemon.sh > Make default wait be longer. > = > = > This addresses bug hbase-2998. > http://issues.apache.org/jira/browse/hbase-2998 > = > = > Diffs > ----- > = > trunk/bin/hbase 1025785 = > trunk/bin/hbase-daemon.sh 1025785 = > trunk/src/main/java/org/apache/hadoop/hbase/master/handler/OpenedRegion= Handler.java 1025785 = > trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.= java 1025785 = > trunk/src/main/java/org/apache/hadoop/hbase/regionserver/ShutdownHook.j= ava 1025785 = > trunk/src/main/java/org/apache/hadoop/hbase/regionserver/handler/OpenRe= gionHandler.java 1025785 = > trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKServerTool.java= 1025785 = > trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperMainServ= erArg.java PRE-CREATION = > trunk/src/test/java/org/apache/hadoop/hbase/zookeeper/TestZooKeeperMain= ServerArg.java PRE-CREATION = > = > Diff: http://review.cloudera.org/r/1057/diff > = > = > Testing > ------- > = > = > Thanks, > = > stack > = >