hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Gray" <jg...@apache.org>
Subject Review Request: HBASE-2253: Show Block cache hit ratio for requests where cacheBlocks=true
Date Sat, 30 Oct 2010 02:16:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1131/
-----------------------------------------------------------

Review request for hbase, stack and Jean-Daniel Cryans.


Summary
-------

LruBlockCache now tracks the hitCachingCount and missCachingCount.  These are hits/misses
when caching of blocks is turned on so the hitCachingRatio does not include the impact of
reads which were not going to cache.

Exposes this new ratio in metrics and in all of the logging/toString methods.

Small optimization in CacheStats to not track hit/miss/access, just compute access from hit+miss.


This addresses bug HBASE-2253.
    http://issues.apache.org/jira/browse/HBASE-2253


Diffs
-----

  trunk/src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCache.java 1028936 
  trunk/src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java 1028936 
  trunk/src/main/java/org/apache/hadoop/hbase/io/hfile/LruBlockCache.java 1028936 
  trunk/src/main/java/org/apache/hadoop/hbase/io/hfile/SimpleBlockCache.java 1028936 
  trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 1028936 
  trunk/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerMetrics.java
1028936 
  trunk/src/test/java/org/apache/hadoop/hbase/io/hfile/TestLruBlockCache.java 1028936 

Diff: http://review.cloudera.org/r/1131/diff


Testing
-------

Ran the block cache test.


Thanks,

Jonathan


Mime
View raw message