hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From st...@duboce.net
Subject Re: Review Request: HBASE-3160: Use more intelligent priorities for PriorityCompactionQueue
Date Fri, 29 Oct 2010 05:51:06 GMT


> On 2010-10-28 22:04:28, Ted Yu wrote:
> > trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java, line 3258
> > <http://review.cloudera.org/r/1103/diff/2/?file=16195#file16195line3258>
> >
> >     Seems to be typo here.
> >     Should be: this region should have
> 
> Nicolas wrote:
>     will fix
> 
> stack wrote:
>     OK... put up a new patch N and I'll commit.

Nm nicolas... I'll fix this on commit... Committing now.


- stack


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1103/#review1698
-----------------------------------------------------------


On 2010-10-28 22:47:02, Nicolas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.cloudera.org/r/1103/
> -----------------------------------------------------------
> 
> (Updated 2010-10-28 22:47:02)
> 
> 
> Review request for hbase.
> 
> 
> Summary
> -------
> 
> Switch to more intelligent priority metric: blockingSize - max(len(s.storefiles) for
s in region.stores) . This will allow us to better prioritize, give us faster responsiveness
to users, and feel more cavalier about issuing new compaction requests.  Note that we also
found/fixed a major compaction downgrade bug while writing this code.
> 
> 
> This addresses bug HBASE-3160.
>     http://issues.apache.org/jira/browse/HBASE-3160
> 
> 
> Diffs
> -----
> 
>   trunk/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplitThread.java 1027787

>   trunk/src/main/java/org/apache/hadoop/hbase/regionserver/CompactionRequestor.java 1027787

>   trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 1027787 
>   trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 1027787

>   trunk/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreFlusher.java 1027787

>   trunk/src/main/java/org/apache/hadoop/hbase/regionserver/PriorityCompactionQueue.java
1027787 
>   trunk/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java 1027787 
>   trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestPriorityCompactionQueue.java
1027787 
> 
> Diff: http://review.cloudera.org/r/1103/diff
> 
> 
> Testing
> -------
> 
> mvn clean install -Dtest=TestPriorityCompaction
> dev cluster tests (on 0.89)
> 
> 
> Thanks,
> 
> Nicolas
> 
>


Mime
View raw message