hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From st...@duboce.net
Subject Re: Review Request: HBASE-3160: Use more intelligent priorities for PriorityCompactionQueue
Date Fri, 29 Oct 2010 05:47:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1103/
-----------------------------------------------------------

(Updated 2010-10-28 22:47:02.663004)


Review request for hbase.


Changes
-------

Just saying I'll commit after you put up new version Nicolas.


Summary
-------

Switch to more intelligent priority metric: blockingSize - max(len(s.storefiles) for s in
region.stores) . This will allow us to better prioritize, give us faster responsiveness to
users, and feel more cavalier about issuing new compaction requests.  Note that we also found/fixed
a major compaction downgrade bug while writing this code.


This addresses bug HBASE-3160.
    http://issues.apache.org/jira/browse/HBASE-3160


Diffs (updated)
-----

  trunk/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplitThread.java 1027787

  trunk/src/main/java/org/apache/hadoop/hbase/regionserver/CompactionRequestor.java 1027787

  trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 1027787 
  trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 1027787 
  trunk/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreFlusher.java 1027787 
  trunk/src/main/java/org/apache/hadoop/hbase/regionserver/PriorityCompactionQueue.java 1027787

  trunk/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java 1027787 
  trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestPriorityCompactionQueue.java
1027787 

Diff: http://review.cloudera.org/r/1103/diff


Testing
-------

mvn clean install -Dtest=TestPriorityCompaction
dev cluster tests (on 0.89)


Thanks,

Nicolas


Mime
View raw message