hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From st...@duboce.net
Subject Re: Review Request: Tool to verify data in two clusters
Date Thu, 28 Oct 2010 23:52:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1111/#review1693
-----------------------------------------------------------

Ship it!


Excellent.  Minor items to address on commit.  So, is this new fancy tool doc'd in replication
notes?  I think it kinda critical.  Would suggest opening a doc issue against 0.90 to mention
presence of this tool in the replication chapter.... if only a sentence.


/trunk/src/main/java/org/apache/hadoop/hbase/mapreduce/replication/VerifyReplication.java
<http://review.cloudera.org/r/1111/#comment5603>

    Missing '<p>' here?



/trunk/src/main/java/org/apache/hadoop/hbase/mapreduce/replication/VerifyReplication.java
<http://review.cloudera.org/r/1111/#comment5602>

    Space around the '+'



/trunk/src/main/java/org/apache/hadoop/hbase/mapreduce/replication/VerifyReplication.java
<http://review.cloudera.org/r/1111/#comment5604>

    Put this in Result?


- stack


On 2010-10-28 16:42:25, Jean-Daniel Cryans wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.cloudera.org/r/1111/
> -----------------------------------------------------------
> 
> (Updated 2010-10-28 16:42:25)
> 
> 
> Review request for hbase.
> 
> 
> Summary
> -------
> 
> This new mapreduce job called VerifyReplication compares the data between two clusters
that are replication-enabled. Its usage is relatively simple when you already use replication,
and even let's you pass the peer id instead of the cluster key for the target cluster.
> 
> 
> This addresses bug HBASE-3013.
>     http://issues.apache.org/jira/browse/HBASE-3013
> 
> 
> Diffs
> -----
> 
>   /trunk/src/main/java/org/apache/hadoop/hbase/mapreduce/Driver.java 1028470 
>   /trunk/src/main/java/org/apache/hadoop/hbase/mapreduce/replication/VerifyReplication.java
PRE-CREATION 
>   /trunk/src/main/java/org/apache/hadoop/hbase/replication/ReplicationZookeeper.java
1028470 
>   /trunk/src/test/java/org/apache/hadoop/hbase/replication/TestReplication.java 1028470

> 
> Diff: http://review.cloudera.org/r/1111/diff
> 
> 
> Testing
> -------
> 
> Unit test (one new included) and this has been running for a month here.
> 
> 
> Thanks,
> 
> Jean-Daniel
> 
>


Mime
View raw message