hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Gray" <jg...@apache.org>
Subject Re: Review Request: TestRollingRestart
Date Mon, 25 Oct 2010 19:30:43 GMT


> On 2010-10-25 12:21:03, stack wrote:
> > Whats wrong w/ this?  Looks good to me.  Other tests would be nice but this does
what rolling restart does now.  Does it pass?

Nothing is wrong with it except that it passes.  Your restarts have shown weird bugs and this
isn't showing it (I don't have my proposed fix applied).

Need to add some concurrent RS stopping though rolling restart should not even do that.


- Jonathan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1090/#review1651
-----------------------------------------------------------


On 2010-10-25 10:15:12, Jonathan Gray wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.cloudera.org/r/1090/
> -----------------------------------------------------------
> 
> (Updated 2010-10-25 10:15:12)
> 
> 
> Review request for hbase and stack.
> 
> 
> Summary
> -------
> 
> First go at a TestRollingRestart.  Needs more work / harder tests per comments in the
test.
> 
> 
> Diffs
> -----
> 
>   trunk/src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java 1026935 
>   trunk/src/test/java/org/apache/hadoop/hbase/master/TestRollingRestart.java PRE-CREATION

> 
> Diff: http://review.cloudera.org/r/1090/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jonathan
> 
>


Mime
View raw message