hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From st...@duboce.net
Subject Re: Review Request: Fix periodic major compaction (HBASE-2990) and expiration check (HBASE-3083)
Date Mon, 25 Oct 2010 16:06:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1089/#review1647
-----------------------------------------------------------



trunk/src/main/java/org/apache/hadoop/hbase/HRegionInfo.java
<http://review.cloudera.org/r/1089/#comment5527>

    I thought you could add random key/values to HRI already?  Hmm... no, you can't.  Its
only to HCD.  Ok.  Its versioned but we don't actually write out the versioning.   How you
going to persist the change?   Write it to FS?  Everytime we major compact?  Want to write
it into .META. instead?  Can it be ephemeral info on the HRI or does it have to persist?



trunk/src/main/java/org/apache/hadoop/hbase/HRegionInfo.java
<http://review.cloudera.org/r/1089/#comment5528>

    Yeah, migrating to new HRI will be a prob. w/o versioning.



trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionData.java
<http://review.cloudera.org/r/1089/#comment5529>

    Check HCD?


- stack


On 2010-10-25 08:33:33, Jonathan Gray wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.cloudera.org/r/1089/
> -----------------------------------------------------------
> 
> (Updated 2010-10-25 08:33:33)
> 
> 
> Review request for hbase, stack and khemani.
> 
> 
> Summary
> -------
> 
> This is a somewhat misguided attempt.  It's not done but it shows the fairly simple change
to the actual major compaction code.
> 
> The hard part is:
> 
> +    long lastMajor = region.getRegionInfo().getRegionData().getLastMajor();
> 
> And the question is where to persist that.
> 
> This patch adds a new class called HRegionData into HRegionInfo that contains any number
of key-value pairs of data that get persisted with the HRI.  Not really sure how I ended up
there but this data seemed like an odd-man-out so adding another field seemed weird.  We also
need some kind of versioning in HRI so we can add stuff w/o migrating.  There's some versioned
stuff in HRData.
> 
> Just looking for some feedback / ideas.
> 
> 
> This addresses bugs HBASE-2990 and HBASE-3083.
>     http://issues.apache.org/jira/browse/HBASE-2990
>     http://issues.apache.org/jira/browse/HBASE-3083
> 
> 
> Diffs
> -----
> 
>   trunk/src/main/java/org/apache/hadoop/hbase/HRegionInfo.java 1026935 
>   trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionData.java PRE-CREATION

>   trunk/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java 1026935 
> 
> Diff: http://review.cloudera.org/r/1089/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jonathan
> 
>


Mime
View raw message