hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Gray" <jg...@apache.org>
Subject Re: Review Request: Unit test and fix for multi-threaded executor service
Date Sat, 23 Oct 2010 02:40:39 GMT


> On 2010-10-22 19:12:22, Benoit Sigoure wrote:
> >

Hey Benoit.  Sorry should have thrown a comment up here.  This isn't going to get committed,
Stack has a different implementation over in HBASE-3319.  We'll eventually need a PQ but for
now it'll get switched to a LinkedBlockingQueue and there's no extra class.

Thanks for review though.  I kinda figured that getActiveCount() was not ideal but thanks
for digging in.


- Jonathan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1064/#review1629
-----------------------------------------------------------


On 2010-10-21 14:59:17, Jonathan Gray wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.cloudera.org/r/1064/
> -----------------------------------------------------------
> 
> (Updated 2010-10-21 14:59:17)
> 
> 
> Review request for hbase and stack.
> 
> 
> Summary
> -------
> 
> See HBASE-3139
> 
> 
> Diffs
> -----
> 
>   trunk/src/main/java/org/apache/hadoop/hbase/executor/ExecutorService.java 1026145 
>   trunk/src/test/java/org/apache/hadoop/hbase/executor/TestExecutorService.java PRE-CREATION

> 
> Diff: http://review.cloudera.org/r/1064/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jonathan
> 
>


Mime
View raw message