hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From st...@duboce.net
Subject Re: Review Request: Unit test and fix for multi-threaded executor service
Date Thu, 21 Oct 2010 22:02:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1064/#review1605
-----------------------------------------------------------

Ship it!


+1  Missing explaination of why you have to make this crazy hbase queue in first place.


trunk/src/main/java/org/apache/hadoop/hbase/executor/ExecutorService.java
<http://review.cloudera.org/r/1064/#comment5413>

    Doc why this oddness.



trunk/src/main/java/org/apache/hadoop/hbase/executor/ExecutorService.java
<http://review.cloudera.org/r/1064/#comment5412>

    Say why we even need this crazy queue; i.e. because excecutorservice is weird.


- stack


On 2010-10-21 14:59:17, Jonathan Gray wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.cloudera.org/r/1064/
> -----------------------------------------------------------
> 
> (Updated 2010-10-21 14:59:17)
> 
> 
> Review request for hbase and stack.
> 
> 
> Summary
> -------
> 
> See HBASE-3139
> 
> 
> Diffs
> -----
> 
>   trunk/src/main/java/org/apache/hadoop/hbase/executor/ExecutorService.java 1026145 
>   trunk/src/test/java/org/apache/hadoop/hbase/executor/TestExecutorService.java PRE-CREATION

> 
> Diff: http://review.cloudera.org/r/1064/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jonathan
> 
>


Mime
View raw message