hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Purtell" <apurt...@apache.org>
Subject Re: Review Request: hbase-2658 REST (stargate) TableRegionModel Regions need to be updated to work w/ new region naming convention from HBASE-2531
Date Thu, 21 Oct 2010 20:27:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1063/#review1602
-----------------------------------------------------------

Ship it!


Looks good.

- Andrew


On 2010-10-21 11:35:11, stack wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.cloudera.org/r/1063/
> -----------------------------------------------------------
> 
> (Updated 2010-10-21 11:35:11)
> 
> 
> Review request for hbase and Andrew Purtell.
> 
> 
> Summary
> -------
> 
> Andrew, can you look at this?  Its making the TableRegionModel do the new HRegionInfo
name format.  Has a few tests even.  I also changed the TestTableResource back to old style
compare of region names and now it passes.
> 
> 
> This addresses bug hbase-2658.
>     http://issues.apache.org/jira/browse/hbase-2658
> 
> 
> Diffs
> -----
> 
>   trunk/src/main/java/org/apache/hadoop/hbase/HRegionInfo.java 1026078 
>   trunk/src/main/java/org/apache/hadoop/hbase/HTableDescriptor.java 1026078 
>   trunk/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java 1026078 
>   trunk/src/main/java/org/apache/hadoop/hbase/rest/model/TableRegionModel.java 1026078

>   trunk/src/main/java/org/apache/hadoop/hbase/util/MetaUtils.java 1026078 
>   trunk/src/test/java/org/apache/hadoop/hbase/rest/TestTableResource.java 1026078 
>   trunk/src/test/java/org/apache/hadoop/hbase/rest/model/TestTableRegionModel.java 1026078

> 
> Diff: http://review.cloudera.org/r/1063/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> stack
> 
>


Mime
View raw message