hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Gray" <jg...@apache.org>
Subject Re: Review Request: Stale reads from ZK can break the atomic CAS operations we have in ZKAssign
Date Wed, 20 Oct 2010 23:47:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1056/
-----------------------------------------------------------

(Updated 2010-10-20 16:47:05.987539)


Review request for hbase, Todd Lipcon and stack.


Changes
-------

Last patch didn't apply for some reason, made a new one.


Summary
-------

Adds a sync(path) operation into ZKW and three calls into it from the CAS operations in ZKAssign.


This addresses bug HBASE-3136.
    http://issues.apache.org/jira/browse/HBASE-3136


Diffs (updated)
-----

  trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKAssign.java 1025790 
  trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java 1025790 

Diff: http://review.cloudera.org/r/1056/diff


Testing
-------

Still need to test more.  I'm not sure it's possible (or feasible in a reasonable amount of
time) to make a unit test for this.  We'd probably need to dig into ZK or mock the hell out
of stuff.


Thanks,

Jonathan


Mime
View raw message