hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From st...@duboce.net
Subject Re: Review Request: HBASE-2514 RegionServer should refuse to be assigned a region that use LZO when LZO isn't available
Date Wed, 20 Oct 2010 19:41:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1046/#review1574
-----------------------------------------------------------



trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
<http://review.cloudera.org/r/1046/#comment5291>

    So this String is not defined so we don't do any compression test with this patch, right?
    
    Is this patch what we want?  Issue is about not loading a region that needs lzo.  Thats
one of two things: a new table that has lzo specified though we don't have lzo loaded; or
its an HRS being asked to open a region that was written by another HRS that had lzo installed
 -- and this does not.  In the issue we thought the region should just not be opened.  If
this HRS is errant being the only one w/ no LZO installed, then he'll open non-lzo'd regions.
 As is, HRSs will go down... a whole cluster could go down just because a silly admin enabled
lzo on a table that had a region per HRS in a cluster.


- stack


On 2010-10-18 19:30:09, Ryan Rawson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.cloudera.org/r/1046/
> -----------------------------------------------------------
> 
> (Updated 2010-10-18 19:30:09)
> 
> 
> Review request for hbase.
> 
> 
> Summary
> -------
> 
> RegionServer should refuse to be assigned a region that use LZO when LZO isn't available
> 
> - instead of checking regions during open, i do a check and throw during the construction
of the RS that is is able to instantiate the listed codecs.
> 
> 
> This addresses bug HBASE-2514.
>     http://issues.apache.org/jira/browse/HBASE-2514
> 
> 
> Diffs
> -----
> 
>   trunk/CHANGES.txt 1024074 
>   trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 1024074

>   trunk/src/main/java/org/apache/hadoop/hbase/util/CompressionTest.java 1024073 
>   trunk/src/test/java/org/apache/hadoop/hbase/util/TestCompressionTest.java PRE-CREATION

> 
> Diff: http://review.cloudera.org/r/1046/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ryan
> 
>


Mime
View raw message