hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Gray" <jg...@apache.org>
Subject Re: Review Request: [rest] publish endpoint and statistics into ZooKeeper
Date Mon, 18 Oct 2010 23:27:07 GMT


> On 2010-10-18 15:34:45, Ryan Rawson wrote:
> > src/main/java/org/apache/hadoop/hbase/rest/RESTServlet.java, line 217
> > <http://review.cloudera.org/r/1039/diff/1/?file=14874#file14874line217>
> >
> >     this looks clever, is it more generically useful to other parts of hbase?
> 
> Andrew Purtell wrote:
>     Other parts of HBase use ZKW methods to do this. I brought this in here to do the
same without pulling in all of the behavior of ZKW I didn't want.

Which behaviors of ZKW are you referring to?  Hopefully this component is generally reusable
(the new ZooKeeperWatcher) and could be used even in limited contexts.  Using it as the primary
watcher and registering with it also helps when writing unit test.  You'd then use ZKUtil
methods for this kind of stuff and inherit work done there.

We are going to need one more level underneath ZKUtil or underlying ZKUtil that manages retry
policies and such.  I'm going to target that for 0.92.  And if all our code uses these APIs
then it will be easier to be consistent.

The patch looks fine to me though so we can work at unifying later and not blocking you on
this.


- Jonathan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1039/#review1560
-----------------------------------------------------------


On 2010-10-18 14:46:30, Andrew Purtell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.cloudera.org/r/1039/
> -----------------------------------------------------------
> 
> (Updated 2010-10-18 14:46:30)
> 
> 
> Review request for hbase.
> 
> 
> Summary
> -------
> 
> This change allows the REST interface to publish its endpoint and metrics, currently
only requests/sec, into ZooKeeper. By default a permanent znode tree is created as needed
at /hbase/rest/status and Stargate instances create ephemeral children of this with names
in the format <host>:<port>. The ephemeral znodes contain JSON serialized information
about the instance, e.g.
> 
>   {"connector":{"host":"restserver.example.com","port":"8080"},"statistics":{"requests":"13"}}
> 
> The function of Stargate itself is not affected, except for one significant change: now
if the ZooKeeper service is lost, the Stargate instances will abort along with the rest of
HBase.
> 
> 
> This addresses bug HBASE-3119.
>     http://issues.apache.org/jira/browse/HBASE-3119
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/hadoop/hbase/HConstants.java 71c3e7b 
>   src/main/java/org/apache/hadoop/hbase/rest/Main.java 368b4b4 
>   src/main/java/org/apache/hadoop/hbase/rest/RESTServlet.java ed92857 
>   src/main/java/org/apache/hadoop/hbase/rest/metrics/RESTMetrics.java 284bbc5 
> 
> Diff: http://review.cloudera.org/r/1039/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew
> 
>


Mime
View raw message