hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Gray" <jg...@apache.org>
Subject Re: Review Request: [rest/stargate] Improve error response when trying to create a scanner on a nonexistant table
Date Wed, 06 Oct 2010 22:08:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/977/#review1459
-----------------------------------------------------------

Ship it!


Looks good to me.  I think in other parts of code we'll do something like: if (e instanceof
SomeExceptionType) but I guess these two ways are basically equivalent?  Or the instanceof
way would cover more generic stuff like seeing if something is an IOE but would work even
if the actual constructed class was something else but that extended IOE.

- Jonathan


On 2010-10-06 15:00:19, Andrew Purtell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.cloudera.org/r/977/
> -----------------------------------------------------------
> 
> (Updated 2010-10-06 15:00:19)
> 
> 
> Review request for hbase.
> 
> 
> Summary
> -------
> 
> Return 404 when an attempt is made to create a scanner on a nonexistent table. 
> 
> 
> This addresses bug HBASE-2907.
>     http://issues.apache.org/jira/browse/HBASE-2907
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/hadoop/hbase/rest/ScannerResource.java 6ee7230 
>   src/test/java/org/apache/hadoop/hbase/rest/TestScannerResource.java bc9fb8b 
> 
> Diff: http://review.cloudera.org/r/977/diff
> 
> 
> Testing
> -------
> 
> New unit test, passes.
> 
> 
> Thanks,
> 
> Andrew
> 
>


Mime
View raw message