hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Gray" <jg...@apache.org>
Subject Re: Review Request: Add ability to have multiple Masters in LocalHBaseCluster for test writing
Date Wed, 06 Oct 2010 21:14:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/925/
-----------------------------------------------------------

(Updated 2010-10-06 14:14:23.202596)


Review request for hbase, stack, Karthik Ranganathan, and Kannan Muthukkaruppan.


Changes
-------

More cleanup of comments.  Removed last remnants of numbering.  Undid some of the code cleanup
my IDE did around single line ifs.


Summary
-------

To really be able to unit test the new master properly, we need to be able to have multiple
masters running at once within a single logical cluster.

Also exposes methods to get the currently active master and can access each individually in
the same way that it's done for multiple RS.

This is mostly duplicating what we do for RS but for masters.


This addresses bug HBASE-3053.
    http://issues.apache.org/jira/browse/HBASE-3053


Diffs (updated)
-----

  trunk/src/main/java/org/apache/hadoop/hbase/HConstants.java 1004853 
  trunk/src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java 1004853 
  trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java 1004853 
  trunk/src/main/java/org/apache/hadoop/hbase/master/HMasterCommandLine.java 1004853 
  trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 1004853 
  trunk/src/main/java/org/apache/hadoop/hbase/util/JVMClusterUtil.java 1004853 
  trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java 1004853 
  trunk/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java 1004853 
  trunk/src/test/java/org/apache/hadoop/hbase/MiniHBaseCluster.java 1004853 
  trunk/src/test/java/org/apache/hadoop/hbase/master/TestMasterFailover.java PRE-CREATION


Diff: http://review.cloudera.org/r/925/diff


Testing
-------

Untested but compiles.  This is first go at a patch.  I'm going to work on writing a new unit
test that uses this next.


Thanks,

Jonathan


Mime
View raw message