hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From st...@duboce.net
Subject Re: Review Request: hbase-3068 IllegalStateException when new server comes online, is given 200 regions to open and 200th region gets timed out of regions in transition
Date Fri, 01 Oct 2010 21:05:45 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated 2010-10-01 14:05:45.726776)

Review request for hbase and Jonathan Gray.


Update to javadoc and comments


Fix is two-fold.

First, added new facility where on successful open, we go and update the timers on all regions
in transition that were on the same server.

Secondly, in the timeout monitor, we'll do necessary cleanup and state transitions so that
when we go into re-assign, we have the proper state

M src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
  Changed regionPlans to be a concurrentskiplist.  Makes life easier
  and in no place do we need lock on regionPlans to span other than
  regionPlans changes.
  Added to the processing of successful region open, the cleanup
  of its regionPlan and a run of updateTimers.
  Put setOffline in place of some code that duplicated what it did.

This addresses bug hbase-3068.

Diffs (updated)

  trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java 1003330 

Diff: http://review.cloudera.org/r/930/diff


Basic unit tests seem to be passing.  Testing now up on cluster.



View raw message