Return-Path: Delivered-To: apmail-hbase-dev-archive@www.apache.org Received: (qmail 7294 invoked from network); 15 Sep 2010 22:26:19 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 15 Sep 2010 22:26:19 -0000 Received: (qmail 85417 invoked by uid 500); 15 Sep 2010 22:26:19 -0000 Delivered-To: apmail-hbase-dev-archive@hbase.apache.org Received: (qmail 85335 invoked by uid 500); 15 Sep 2010 22:26:18 -0000 Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hbase.apache.org Delivered-To: mailing list dev@hbase.apache.org Received: (qmail 85310 invoked by uid 99); 15 Sep 2010 22:26:18 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 15 Sep 2010 22:26:18 +0000 X-ASF-Spam-Status: No, hits=1.8 required=10.0 tests=FH_HELO_EQ_D_D_D_D,FREEMAIL_FROM,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (nike.apache.org: 184.73.217.71 is neither permitted nor denied by domain of ryanobjc@gmail.com) Received: from [184.73.217.71] (HELO ip-10-202-7-187.ec2.internal) (184.73.217.71) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 15 Sep 2010 22:26:11 +0000 Received: from ip-10-202-7-187.ec2.internal (localhost [127.0.0.1]) by ip-10-202-7-187.ec2.internal (Postfix) with ESMTP id 502138A1FA; Wed, 15 Sep 2010 22:25:51 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Subject: Re: Review Request: HBASE-2997 performance improvements From: "Ryan Rawson" To: "Ryan Rawson" , jiraposter@review.hbase.org, dev@hbase.apache.org Date: Wed, 15 Sep 2010 22:25:51 -0000 Message-ID: <20100915222551.20479.51647@ip-10-202-7-187.ec2.internal> In-Reply-To: <20100914224102.20451.66587@ip-10-202-7-187.ec2.internal> References: <20100914224102.20451.66587@ip-10-202-7-187.ec2.internal> X-Virus-Checked: Checked by ClamAV on apache.org ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/843/#review1230 ----------------------------------------------------------- src/main/java/org/apache/hadoop/hbase/KeyValue.java key values are only used by 1 thread at a time, so no. = and even if they were shared, we'd just result in the current situation= - use more cpu than is theoretically necessary. src/main/java/org/apache/hadoop/hbase/KeyValue.java it actually is worth it... also key values tend to be short lived, but = recopying this array out half a dozen times during a scan is pricy accordin= g to the profiler. 6% cpu. src/main/java/org/apache/hadoop/hbase/KeyValue.java in a 64 bit jvm you cannot read a partial long, the updates are atomic. = this is part of the spec. also single threaded comment above. - Ryan On 2010-09-14 15:41:01, Ryan Rawson wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.cloudera.org/r/843/ > ----------------------------------------------------------- > = > (Updated 2010-09-14 15:41:01) > = > = > Review request for hbase. > = > = > Summary > ------- > = > HBASE-2997 performance improvements > = > = > This addresses bug HBASE-2997. > http://issues.apache.org/jira/browse/HBASE-2997 > = > = > Diffs > ----- > = > src/main/java/org/apache/hadoop/hbase/KeyValue.java abd5a6b = > = > Diff: http://review.cloudera.org/r/843/diff > = > = > Testing > ------- > = > = > Thanks, > = > Ryan > = >