Return-Path: Delivered-To: apmail-hbase-dev-archive@www.apache.org Received: (qmail 61410 invoked from network); 15 Sep 2010 01:02:04 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 15 Sep 2010 01:02:04 -0000 Received: (qmail 30914 invoked by uid 500); 15 Sep 2010 01:02:04 -0000 Delivered-To: apmail-hbase-dev-archive@hbase.apache.org Received: (qmail 30838 invoked by uid 500); 15 Sep 2010 01:02:03 -0000 Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hbase.apache.org Delivered-To: mailing list dev@hbase.apache.org Received: (qmail 30830 invoked by uid 99); 15 Sep 2010 01:02:03 -0000 Received: from Unknown (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 15 Sep 2010 01:02:03 +0000 X-ASF-Spam-Status: No, hits=1.8 required=10.0 tests=FH_HELO_EQ_D_D_D_D,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (nike.apache.org: local policy) Received: from [184.73.217.71] (HELO ip-10-202-7-187.ec2.internal) (184.73.217.71) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 15 Sep 2010 01:01:41 +0000 Received: from ip-10-202-7-187.ec2.internal (localhost [127.0.0.1]) by ip-10-202-7-187.ec2.internal (Postfix) with ESMTP id 25F558A1FA; Wed, 15 Sep 2010 01:01:21 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Subject: Re: Review Request: HBASE-2941 reader threads for hbase rpc From: "Todd Lipcon" To: "Ryan Rawson" , "Todd Lipcon" , jiraposter@review.hbase.org, dev@hbase.apache.org Date: Wed, 15 Sep 2010 01:01:21 -0000 Message-ID: <20100915010121.20451.45759@ip-10-202-7-187.ec2.internal> In-Reply-To: <20100914224346.20451.87608@ip-10-202-7-187.ec2.internal> References: <20100914224346.20451.87608@ip-10-202-7-187.ec2.internal> X-Virus-Checked: Checked by ClamAV on apache.org ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/846/#review1216 ----------------------------------------------------------- Ship it! src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java do you not have to wait here until indication that the selector thread = has woken up and is in the "wait" loop? I'm not 100% sure of the state prec= onditions for the NIO stuff - Todd On 2010-09-14 15:43:46, Ryan Rawson wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.cloudera.org/r/846/ > ----------------------------------------------------------- > = > (Updated 2010-09-14 15:43:46) > = > = > Review request for hbase. > = > = > Summary > ------- > = > HBASE-2941 reader threads for hbase rpc > = > = > This addresses bug HBASE-2941. > http://issues.apache.org/jira/browse/HBASE-2941 > = > = > Diffs > ----- > = > src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java d3c6c21 = > = > Diff: http://review.cloudera.org/r/846/diff > = > = > Testing > ------- > = > = > Thanks, > = > Ryan > = >