Return-Path: Delivered-To: apmail-hbase-dev-archive@www.apache.org Received: (qmail 56626 invoked from network); 14 Sep 2010 01:55:20 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 14 Sep 2010 01:55:20 -0000 Received: (qmail 3051 invoked by uid 500); 14 Sep 2010 01:55:20 -0000 Delivered-To: apmail-hbase-dev-archive@hbase.apache.org Received: (qmail 2991 invoked by uid 500); 14 Sep 2010 01:55:19 -0000 Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hbase.apache.org Delivered-To: mailing list dev@hbase.apache.org Received: (qmail 2983 invoked by uid 99); 14 Sep 2010 01:55:19 -0000 Received: from Unknown (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 14 Sep 2010 01:55:19 +0000 X-ASF-Spam-Status: No, hits=1.8 required=10.0 tests=FH_HELO_EQ_D_D_D_D,MIME_QP_LONG_LINE,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (nike.apache.org: local policy) Received: from [184.73.217.71] (HELO ip-10-202-7-187.ec2.internal) (184.73.217.71) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 14 Sep 2010 01:54:57 +0000 Received: from ip-10-202-7-187.ec2.internal (localhost [127.0.0.1]) by ip-10-202-7-187.ec2.internal (Postfix) with ESMTP id 827A08A1FA; Tue, 14 Sep 2010 01:54:36 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Subject: Re: Review Request: Refactor master and RS to conform to Guava service lifecycle interface From: "Jonathan Gray" To: "Jonathan Gray" , stack@duboce.net Date: Tue, 14 Sep 2010 01:54:36 -0000 Message-ID: <20100914015436.21811.58651@ip-10-202-7-187.ec2.internal> Cc: "Todd Lipcon" , jiraposter@review.hbase.org, dev@hbase.apache.org In-Reply-To: <20100914013630.21810.88294@ip-10-202-7-187.ec2.internal> References: <20100914013630.21810.88294@ip-10-202-7-187.ec2.internal> X-Virus-Checked: Checked by ClamAV on apache.org ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/829/#review1173 ----------------------------------------------------------- I like this. Naming seems fine to me. We're making great strides in clean= ing these things up, great stuff Todd. I guess we're in need of standardizing the methods in HM and HRS like toStr= ing, get*Name, etc... src/main/java/org/apache/hadoop/hbase/master/HMaster.java The toString() is supposed to give a unique name for the instance, espe= cially useful in unit tests with multiple masters and such. Not sure where= all we're using getServerName but might make sense for these to be the sam= e. - Jonathan On 2010-09-13 18:36:29, Todd Lipcon wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.cloudera.org/r/829/ > ----------------------------------------------------------- > = > (Updated 2010-09-13 18:36:29) > = > = > Review request for hbase, stack and Jonathan Gray. > = > = > Summary > ------- > = > This isn't really cleaned up, but wanted to gather opinions before I put = in more effort. Does this kind of refactor seem good? Is the Guava "Service= " class what we want to use or should we just write our own similar interfa= ce? > = > = > This addresses bug HBASE-2993. > http://issues.apache.org/jira/browse/HBASE-2993 > = > = > Diffs > ----- > = > src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java bc0a62f = > src/main/java/org/apache/hadoop/hbase/master/HMaster.java bc21a1e = > src/main/java/org/apache/hadoop/hbase/master/HMasterCommandLine.java c6= 75db9 = > src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java b= ba7b67 = > src/main/java/org/apache/hadoop/hbase/service/ServiceUtils.java PRE-CRE= ATION = > src/main/java/org/apache/hadoop/hbase/service/ServiceWithMainThread.jav= a PRE-CREATION = > src/main/java/org/apache/hadoop/hbase/util/JVMClusterUtil.java 4a9f1c3 = > src/test/java/org/apache/hadoop/hbase/HBaseClusterTestCase.java b7abb51 = > src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java 9cc1168 = > src/test/java/org/apache/hadoop/hbase/MiniHBaseCluster.java 9407c1e = > src/test/java/org/apache/hadoop/hbase/TestHBaseTestingUtility.java 1cd8= 8d3 = > src/test/java/org/apache/hadoop/hbase/TestInfoServers.java daffe02 = > src/test/java/org/apache/hadoop/hbase/TestRegionRebalancing.java 690811= 1 = > src/test/java/org/apache/hadoop/hbase/master/TestKillingServersFromMast= er.java f5fd243 = > src/test/java/org/apache/hadoop/hbase/master/TestZKBasedOpenCloseRegion= .java a172e2c = > src/test/java/org/apache/hadoop/hbase/regionserver/DisabledTestRegionSe= rverExit.java 5b8b464 = > src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestLogRolling.j= ava 287f1fb = > = > Diff: http://review.cloudera.org/r/829/diff > = > = > Testing > ------- > = > Tried to run unit tests, but plenty failed. I think they're failing on tr= unk, too, though. Will do more testing and another round of review before I= actually claim this is ready to commit. > = > = > Thanks, > = > Todd > = >