Return-Path: Delivered-To: apmail-hbase-dev-archive@www.apache.org Received: (qmail 79799 invoked from network); 13 Sep 2010 17:17:05 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 13 Sep 2010 17:17:05 -0000 Received: (qmail 83723 invoked by uid 500); 13 Sep 2010 17:17:04 -0000 Delivered-To: apmail-hbase-dev-archive@hbase.apache.org Received: (qmail 83672 invoked by uid 500); 13 Sep 2010 17:17:04 -0000 Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hbase.apache.org Delivered-To: mailing list dev@hbase.apache.org Received: (qmail 83664 invoked by uid 99); 13 Sep 2010 17:17:04 -0000 Received: from Unknown (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 13 Sep 2010 17:17:04 +0000 X-ASF-Spam-Status: No, hits=1.8 required=10.0 tests=FH_HELO_EQ_D_D_D_D,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (nike.apache.org: local policy) Received: from [184.73.217.71] (HELO ip-10-202-7-187.ec2.internal) (184.73.217.71) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 13 Sep 2010 17:16:42 +0000 Received: from ip-10-202-7-187.ec2.internal (localhost [127.0.0.1]) by ip-10-202-7-187.ec2.internal (Postfix) with ESMTP id AF7678A1FA; Mon, 13 Sep 2010 17:16:21 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Subject: Re: Review Request: Support alternate compression for major compactions From: "Todd Lipcon" To: "Andrew Purtell" , "Todd Lipcon" , jiraposter@review.hbase.org, dev@hbase.apache.org Date: Mon, 13 Sep 2010 17:16:21 -0000 Message-ID: <20100913171621.21810.30042@ip-10-202-7-187.ec2.internal> In-Reply-To: <20100913071606.21811.94966@ip-10-202-7-187.ec2.internal> References: <20100913071606.21811.94966@ip-10-202-7-187.ec2.internal> X-Virus-Checked: Checked by ClamAV on apache.org ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/821/#review1163 ----------------------------------------------------------- src/main/java/org/apache/hadoop/hbase/HColumnDescriptor.java This will throw NPE if it's not set, right? Why not just make this return getCompression() if n =3D=3D null, then y= ou can get rid of the hasCompactionCompression() check down in StoreFile be= low and simplify things a bit? = Also why redundant getCompactionCompression and getCompactionCompressio= nType? - Todd On 2010-09-13 00:16:06, Andrew Purtell wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.cloudera.org/r/821/ > ----------------------------------------------------------- > = > (Updated 2010-09-13 00:16:06) > = > = > Review request for hbase. > = > = > Summary > ------- > = > Support alternate compression for major compactions. > = > This is expected to be an uncommmon configuration so I did not pollute th= e HColumnDescriptor constructor with the new option; instead only added con= venience {get,set}ters. > = > = > This addresses bug HBASE-2988. > http://issues.apache.org/jira/browse/HBASE-2988 > = > = > Diffs > ----- > = > src/main/java/org/apache/hadoop/hbase/HColumnDescriptor.java 8e3bd53 = > src/main/java/org/apache/hadoop/hbase/regionserver/Store.java 4f777f0 = > src/main/ruby/hbase/admin.rb 82d7e54 = > = > Diff: http://review.cloudera.org/r/821/diff > = > = > Testing > ------- > = > Created table with LZO compression, inserted 10GB of data, altered schema= with COMPRESSION_COMPACT of 'LZMA' (custom LZMA Hadoop compression plugin)= , initiated major compaction, confirmed the results by examining HFiles on = local fs with the UNIX file utility. > = > = > Thanks, > = > Andrew > = >