hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From st...@duboce.net
Subject Re: Review Request: HBASE-2997 performance improvements
Date Wed, 15 Sep 2010 21:30:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/843/#review1229
-----------------------------------------------------------



src/main/java/org/apache/hadoop/hbase/KeyValue.java
<http://review.cloudera.org/r/843/#comment4186>

    Should this be volatile?



src/main/java/org/apache/hadoop/hbase/KeyValue.java
<http://review.cloudera.org/r/843/#comment4187>

    Is the trade of cpu for memory space worth it here?



src/main/java/org/apache/hadoop/hbase/KeyValue.java
<http://review.cloudera.org/r/843/#comment4188>

    Volatile or is it possible to read partial long?


- stack


On 2010-09-14 15:41:01, Ryan Rawson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.cloudera.org/r/843/
> -----------------------------------------------------------
> 
> (Updated 2010-09-14 15:41:01)
> 
> 
> Review request for hbase.
> 
> 
> Summary
> -------
> 
> HBASE-2997 performance improvements
> 
> 
> This addresses bug HBASE-2997.
>     http://issues.apache.org/jira/browse/HBASE-2997
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/hadoop/hbase/KeyValue.java abd5a6b 
> 
> Diff: http://review.cloudera.org/r/843/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ryan
> 
>


Mime
View raw message